From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9B12E15800F for ; Mon, 6 Feb 2023 13:47:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D2787E07E6; Mon, 6 Feb 2023 13:47:07 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B2B1BE07E6 for ; Mon, 6 Feb 2023 13:47:07 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 38843340AB6 for ; Mon, 6 Feb 2023 13:47:06 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id B9F1385B for ; Mon, 6 Feb 2023 13:47:03 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1675691216.f0a6155b2ec6f737d7258cf9baa75a9aeca8f1de.sam@gentoo> Subject: [gentoo-commits] proj/gentoo-functions:master commit in: / X-VCS-Repository: proj/gentoo-functions X-VCS-Files: functions.sh X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: f0a6155b2ec6f737d7258cf9baa75a9aeca8f1de X-VCS-Branch: master Date: Mon, 6 Feb 2023 13:47:03 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 5ad523f7-463e-4904-a477-4517476464df X-Archives-Hash: c35e238ea3a226d76ec6365d5eb42f8a commit: f0a6155b2ec6f737d7258cf9baa75a9aeca8f1de Author: Kerin Millar plushkava net> AuthorDate: Mon Feb 6 06:27:47 2023 +0000 Commit: Sam James gentoo org> CommitDate: Mon Feb 6 13:46:56 2023 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=f0a6155b Don't unsuccessfully attempt to background the defunct rc_splash utility The media-gfx/splashutils package was dropped in November 2018, and was probably not even usable for some time before that. Currently, every time the _eend() function handles an exit status code other than 0, it tries to run rc_splash in the background with no possible chance of success. It also incurs an utterly useless syscall, in order to determine whether /dev/null is a character device. Cease and desist. Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> functions.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/functions.sh b/functions.sh index ae7d151..0a5d38e 100644 --- a/functions.sh +++ b/functions.sh @@ -235,11 +235,6 @@ _eend() yesno "${EINFO_QUIET}" && return 0 msg="${BRACKET}[ ${GOOD}ok${BRACKET} ]${NORMAL}" else - if [ -c /dev/null ] ; then - rc_splash "stop" >/dev/null 2>&1 & - else - rc_splash "stop" & - fi if [ -n "$*" ] ; then ${efunc} "$*" fi