From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1478429-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2384415800F for <garchives@archives.gentoo.org>; Wed, 18 Jan 2023 18:29:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 50535E08F1; Wed, 18 Jan 2023 18:29:27 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 31798E08F1 for <gentoo-commits@lists.gentoo.org>; Wed, 18 Jan 2023 18:29:27 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 21AC8340ADB for <gentoo-commits@lists.gentoo.org>; Wed, 18 Jan 2023 18:29:26 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 57348771 for <gentoo-commits@lists.gentoo.org>; Wed, 18 Jan 2023 18:29:24 +0000 (UTC) From: "Sam James" <sam@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org> Message-ID: <1674066520.1d65e1921d23cc9471ed4d909429f98bed0bfcf2.sam@gentoo> Subject: [gentoo-commits] proj/qa-scripts:master commit in: / X-VCS-Repository: proj/qa-scripts X-VCS-Files: eapi-usage.sh X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 1d65e1921d23cc9471ed4d909429f98bed0bfcf2 X-VCS-Branch: master Date: Wed, 18 Jan 2023 18:29:24 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 75182e98-38a9-4815-821c-b1f910451a53 X-Archives-Hash: b91ffe10cba3f3fbc3ba2736fc0438a1 commit: 1d65e1921d23cc9471ed4d909429f98bed0bfcf2 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Wed Jan 18 18:28:40 2023 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Wed Jan 18 18:28:40 2023 +0000 URL: https://gitweb.gentoo.org/proj/qa-scripts.git/commit/?id=1d65e192 eapi-usage.sh: update commentary re pinspect usage We previously stopped using it because pkgcore at the time lacked support for newer EAPIs (>= EAPI 5), but now it's less appealing to switch back despite the elegance (and nicer output, I suppose) given the awk works and is a fair bit faster. Signed-off-by: Sam James <sam <AT> gentoo.org> eapi-usage.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/eapi-usage.sh b/eapi-usage.sh index 62e878f..b7a1112 100755 --- a/eapi-usage.sh +++ b/eapi-usage.sh @@ -56,12 +56,14 @@ mv ${TMPDIR}/eapi-usage/*.txt ${dir}/ || exit 1 rm -r "${TMPDIR}" || exit 1 # Now generate the numbers/summary (copied in from previous eapi_usage.sh script) -# Boring 'script' that just uses pkgcore's pinspect command. Someday it would be -# nice to graph this output, or maybe keep some running history? - +# Someday it would be nice to graph this output, or maybe keep some running history? +# TODO: We used pinspect in the past which is cleaner but it's slower than the +# awk method used below (we also stopped using it because at the time, pkgcore +# lacked newer EAPI support). #[[ $(type pinspect 2> /dev/null) ]] || exit 1 # #pinspect eapi_usage /usr/portage + find "${REPO_PATH}"/metadata/md5-cache -type f ! -name '*.gz' \ -exec grep -h '^EAPI=' '{}' + \ | awk '