From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1477802-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id EAA0A15800F for <garchives@archives.gentoo.org>; Sun, 15 Jan 2023 20:37:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3E7BCE0837; Sun, 15 Jan 2023 20:37:03 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 24E32E0837 for <gentoo-commits@lists.gentoo.org>; Sun, 15 Jan 2023 20:37:03 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 5C25533B864 for <gentoo-commits@lists.gentoo.org>; Sun, 15 Jan 2023 20:37:02 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 2EE117F4 for <gentoo-commits@lists.gentoo.org>; Sun, 15 Jan 2023 20:37:00 +0000 (UTC) From: "Sam James" <sam@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org> Message-ID: <1673815017.315341e5af9dad09ca4e5c1ff8b16e3c0fc72898.sam@OpenRC> Subject: [gentoo-commits] proj/netifrc:master commit in: net/ X-VCS-Repository: proj/netifrc X-VCS-Files: net/l2tp.sh X-VCS-Directories: net/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 315341e5af9dad09ca4e5c1ff8b16e3c0fc72898 X-VCS-Branch: master Date: Sun, 15 Jan 2023 20:37:00 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: b53166ab-044a-4b33-a157-04407fa2e746 X-Archives-Hash: b356d3ccf76ef58500130276307d7c58 commit: 315341e5af9dad09ca4e5c1ff8b16e3c0fc72898 Author: Kerin Millar <kfm <AT> plushkava <DOT> net> AuthorDate: Sun Jan 15 19:30:35 2023 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sun Jan 15 20:36:57 2023 +0000 URL: https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=315341e5 net/l2tp.sh: Really favour IFACE over IFVAR in an informational message The previous commit intended to replace an instance of IFVAR with IFACE. Instead, it replaced with IFNAME, which means nothing to netifrc. Frustratingly, I had realised my error at the time of submitting the patch, yet still managed to attach a bad one. Make it right. Signed-off-by: Kerin Millar <kfm <AT> plushkava.net> Signed-off-by: Sam James <sam <AT> gentoo.org> net/l2tp.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/l2tp.sh b/net/l2tp.sh index 2221d26..aa8e3fd 100644 --- a/net/l2tp.sh +++ b/net/l2tp.sh @@ -39,7 +39,7 @@ l2tp_pre_start() { elif ! declared_tunnel=$(_l2tp_parse_opts "${l2tptunnel}" "local peer_tunnel_id remote tunnel_id" "encap"); then eend 1 "${key} is missing at least one required parameter" elif set -- "${tunnel_id}"; eval "${declared_tunnel}"; [ "$1" != "${tunnel_id}" ]; then - eend 1 "${key} defines a \"tunnel_id\" parameter that contradicts l2tpsession_${IFNAME}" + eend 1 "${key} defines a \"tunnel_id\" parameter that contradicts l2tpsession_${IFACE:?}" elif _l2tp_should_add_tunnel "${tunnel_id}" "${declared_tunnel}"; set -- $?; [ "$1" -eq 2 ]; then eend 1 "Tunnel #${tunnel_id} exists but its properties mismatch those defined by ${key}" elif [ "$1" -eq 1 ]; then