From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0B1B215800F for ; Mon, 2 Jan 2023 11:08:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 26900E0825; Mon, 2 Jan 2023 11:08:18 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9050DE0825 for ; Mon, 2 Jan 2023 11:08:16 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 82B9B340D17 for ; Mon, 2 Jan 2023 11:08:15 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id E34A46F2 for ; Mon, 2 Jan 2023 11:08:13 +0000 (UTC) From: "Ionen Wolkens" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ionen Wolkens" Message-ID: <1672657523.0ee6e8f7f063044c104a431bfdc7b9cdc3f577e2.ionen@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: games-emulation/pcsx2/ X-VCS-Repository: repo/gentoo X-VCS-Files: games-emulation/pcsx2/pcsx2-9999.ebuild X-VCS-Directories: games-emulation/pcsx2/ X-VCS-Committer: ionen X-VCS-Committer-Name: Ionen Wolkens X-VCS-Revision: 0ee6e8f7f063044c104a431bfdc7b9cdc3f577e2 X-VCS-Branch: master Date: Mon, 2 Jan 2023 11:08:13 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 054721d6-ec14-4669-8e83-44ccc5a77c99 X-Archives-Hash: 5d1938790319d458766f38627634e4dc commit: 0ee6e8f7f063044c104a431bfdc7b9cdc3f577e2 Author: Ionen Wolkens gentoo org> AuthorDate: Mon Jan 2 10:28:21 2023 +0000 Commit: Ionen Wolkens gentoo org> CommitDate: Mon Jan 2 11:05:23 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ee6e8f7 games-emulation/pcsx2: add comment about upstream May be useful to know for anyone working on this. Upstream doesn't seem to want to hear of non-appimage issues. They also dislike that we do workarounds for these issues and wants it pristine (no patch/sed, even tiny changes like changing the path to find resources in /usr/share given been seemingly refusing to add a cmake option to change it) and using bundled libs. Hopefully may change if it gets a dedicated linux contributor, as there's currently none and it's at most just drive-by PRs which don't get maintained and eventually break. Signed-off-by: Ionen Wolkens gentoo.org> games-emulation/pcsx2/pcsx2-9999.ebuild | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/games-emulation/pcsx2/pcsx2-9999.ebuild b/games-emulation/pcsx2/pcsx2-9999.ebuild index b9d68d63b68b..e2f804a6b008 100644 --- a/games-emulation/pcsx2/pcsx2-9999.ebuild +++ b/games-emulation/pcsx2/pcsx2-9999.ebuild @@ -161,13 +161,17 @@ src_configure() { -DDISABLE_BUILD_DATE=yes -DDISABLE_SETCAP=yes -DENABLE_TESTS=$(usex test) - -DUSE_SYSTEM_LIBS=yes -DUSE_VTUNE=no -DUSE_VULKAN=$(usex vulkan) -DWAYLAND_API=$(usex wayland) -DX11_API=yes # fails if X libs are missing even if disabled -DXDG_STD=yes + # note that the current upstream is somewhat hostile to using system + # libs, system installs, or any modifications and may disregard any + # bugs that is not reproducible with the appimage using bundled libs + -DUSE_SYSTEM_LIBS=yes + # sse4.1 is the bare minimum required, -m is required at build time # (see PCSX2Base.h) and it dies if no support at runtime (AppInit.cpp) # https://github.com/PCSX2/pcsx2/pull/4329 @@ -189,7 +193,6 @@ src_test() { } src_install() { - # package mode was removed turning cmake_src_install into a noop newbin "${BUILD_DIR}"/pcsx2-qt/pcsx2-qt ${PN} insinto /usr/share/${PN}