public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ionen Wolkens" <ionen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-eselect/eselect-wine/
Date: Thu, 17 Nov 2022 07:53:18 +0000 (UTC)	[thread overview]
Message-ID: <1668671578.d4b3ba03339d6a70aae2cc7cf933f76a07392db9.ionen@gentoo> (raw)

commit:     d4b3ba03339d6a70aae2cc7cf933f76a07392db9
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Thu Nov 17 07:50:14 2022 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Thu Nov 17 07:52:58 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4b3ba03

app-eselect/eselect-wine: bigger warning for collision-protect

Easy to miss with the wall of text portage gives.

Note users typically don't have this enabled, it's primarily Gentoo
devs that may use this more aggressive version of protect-owned.

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild b/app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild
index 50b4a4c56409..5129be25c9b1 100644
--- a/app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild
+++ b/app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild
@@ -16,11 +16,17 @@ SLOT="0"
 RDEPEND="app-admin/eselect"
 
 pkg_pretend() {
-	# not-owned {bin,include}/wine is removed by pkg_preinst's unset, but
-	# portage currently checks collisions and errors out /before/ pkg_preinst
-	has_version '<app-eselect/eselect-wine-2' &&
-		has collision-protect ${FEATURES} &&
-		eerror "!Warning! may need to disable FEATURES=collision-protect to merge ${P}"
+	# /usr/bin/wine and /usr/include/wine are removed by pkg_preinst's unset,
+	# but portage currently checks collisions and errors out /before/ preinst
+	if has_version '<app-eselect/eselect-wine-2' &&
+		has collision-protect ${FEATURES}
+	then
+		eerror
+		eerror "!Warning! will likely need to either disable FEATURES=collision-protect or"
+		eerror "delete ${EROOT}/usr/bin/wine and ${EROOT}/usr/include/wine to merge ${P}"
+		eerror "(these files should be orphaned, so default FEATURES=protect-owned is fine)"
+		eerror
+	fi
 }
 
 src_install() {


             reply	other threads:[~2022-11-17  7:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  7:53 Ionen Wolkens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-04-21 19:40 [gentoo-commits] repo/gentoo:master commit in: app-eselect/eselect-wine/ Arthur Zamarin
2025-02-14  8:00 Ionen Wolkens
2024-07-25 21:49 Ionen Wolkens
2023-08-23 15:41 Ionen Wolkens
2023-08-23 15:41 Ionen Wolkens
2023-08-06  4:32 Ionen Wolkens
2023-07-30 19:29 Ionen Wolkens
2023-07-30 16:18 Ionen Wolkens
2023-03-03  5:26 Ionen Wolkens
2022-12-29 20:29 Ionen Wolkens
2022-12-05 20:46 Ionen Wolkens
2022-12-03 22:40 Ionen Wolkens
2022-12-03 14:08 Ionen Wolkens
2022-12-03 13:52 Ionen Wolkens
2022-12-03  1:03 Ionen Wolkens
2022-12-02  3:18 Ionen Wolkens
2022-12-02  3:18 Ionen Wolkens
2022-11-29  0:27 Ionen Wolkens
2022-11-23 20:39 Ionen Wolkens
2022-11-23 20:39 Ionen Wolkens
2022-11-20 17:12 Ionen Wolkens
2022-11-16 17:01 Ionen Wolkens
2022-11-16 15:02 Ionen Wolkens
2022-10-12 13:47 Ionen Wolkens
2022-10-12 13:47 Ionen Wolkens
2022-10-12 13:47 Ionen Wolkens
2022-08-11 18:41 Nick Sarnie
2022-07-24  8:26 Joonas Niilola
2021-02-07  1:43 Sam James
2017-09-29  3:07 NP Hardass
2017-09-28 22:32 NP Hardass
2017-09-15  6:10 NP Hardass
2017-09-15  6:01 NP Hardass
2017-09-13 23:54 NP Hardass
2017-08-07 14:10 NP Hardass
2017-04-12  1:37 NP Hardass
2017-04-11  6:03 NP Hardass
2017-04-10 17:22 NP Hardass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1668671578.d4b3ba03339d6a70aae2cc7cf933f76a07392db9.ionen@gentoo \
    --to=ionen@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox