From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A8826158020 for ; Wed, 9 Nov 2022 03:38:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F20BCE0882; Wed, 9 Nov 2022 03:38:20 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D6AD9E0882 for ; Wed, 9 Nov 2022 03:38:20 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E889C340EC9 for ; Wed, 9 Nov 2022 03:38:19 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 5BFF96DF for ; Wed, 9 Nov 2022 03:38:18 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1667965093.c4df46e3da5fee516dba000ade492c2462db99fd.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: /, bin/install-qa-check.d/ X-VCS-Repository: proj/portage X-VCS-Files: NEWS bin/install-qa-check.d/90gcc-warnings X-VCS-Directories: bin/install-qa-check.d/ / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: c4df46e3da5fee516dba000ade492c2462db99fd X-VCS-Branch: master Date: Wed, 9 Nov 2022 03:38:18 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: b52847de-72b7-4473-9038-5f3b42a70897 X-Archives-Hash: 0f7f2cdd0442680fd187d95935e8a468 commit: c4df46e3da5fee516dba000ade492c2462db99fd Author: Sam James gentoo org> AuthorDate: Wed Nov 9 03:36:39 2022 +0000 Commit: Sam James gentoo org> CommitDate: Wed Nov 9 03:38:13 2022 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=c4df46e3 install-qa-check.d/90gcc-warnings: update outdated -Wformat pattern This only covers missing specifiers. We may add generic -Wformat (as commented out) for time_t & LFS stuff later on, but I don't want to do it in portage 3.0.39 as we're adding enough new stuff here. Signed-off-by: Sam James gentoo.org> NEWS | 3 +++ bin/install-qa-check.d/90gcc-warnings | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index cf3487e4b..6fe36cbe0 100644 --- a/NEWS +++ b/NEWS @@ -30,6 +30,9 @@ Features: * -Wint-to-pointer-cast * -Wpointer-to-int-cast * -Wint-to-void-pointer-cast + * Further -Wformat matches for missing specifiers. + In future, we may warn on all -Wformat (in particular because of e.g. + time_t & LFS). * install-qa-check.d: 90gcc-warnings: Always die on -Wimplicit-function-declaration and remove bin/check-implicit-pointer-usage.py of dubious licencing (it was diff --git a/bin/install-qa-check.d/90gcc-warnings b/bin/install-qa-check.d/90gcc-warnings index cdffcd029..d8322871b 100644 --- a/bin/install-qa-check.d/90gcc-warnings +++ b/bin/install-qa-check.d/90gcc-warnings @@ -69,8 +69,12 @@ gcc_warn_check() { # warning: cast from ... to integer of different size 'warning: .*\[-Wpointer-to-int-cast\]' - # outdated? + # -Wformat + # TODO: comment out some time in future for time_t & LFS preparedness + #'warning: .*\[-Wformat=\]' + # -Wformat variants 'warning: .*too few arguments for format' + 'warning: .*missing sentinel in function call.*\[-Wformat=\]' # format ... expects a matching ... argument # (iow, too few arguments for format in new wording :)) 'warning: .*matching.*\[-Wformat=\]'