From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 12FB0158021 for ; Thu, 20 Oct 2022 08:05:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1140CE08C3; Thu, 20 Oct 2022 08:05:47 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DF828E08AD for ; Thu, 20 Oct 2022 08:05:46 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D200A340D69 for ; Thu, 20 Oct 2022 08:05:45 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id F1A23615 for ; Thu, 20 Oct 2022 08:05:43 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1666253103.f567f94fe7f413b9d8d20aca3c48fb1d84a23985.ulm@gentoo> Subject: [gentoo-commits] repo/proj/emacs:master commit in: eclass/ X-VCS-Repository: repo/proj/emacs X-VCS-Files: eclass/elisp-common.eclass X-VCS-Directories: eclass/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: f567f94fe7f413b9d8d20aca3c48fb1d84a23985 X-VCS-Branch: master Date: Thu, 20 Oct 2022 08:05:43 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 240e567f-d45a-49db-9a9a-b752092bfe1f X-Archives-Hash: e6a7da342e5e3d91b8d77106dac324f1 commit: f567f94fe7f413b9d8d20aca3c48fb1d84a23985 Author: Sam James gentoo org> AuthorDate: Thu Aug 18 19:18:20 2022 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Thu Oct 20 08:05:03 2022 +0000 URL: https://gitweb.gentoo.org/repo/proj/emacs.git/commit/?id=f567f94f elisp-common.eclass: fix for Emacs 29 (explicitly require autoload) Emacs 29's NEWS says: "The autoload.el library is now obsolete." We should therefore explicitly 'require it in order to have the eclass machinery work. Fix build failures with e.g. exec-path-from-shell, flycheck: ``` * Generating autoload file for GNU Emacs ... Error: void-function (batch-update-autoloads) debug-early-backtrace() debug-early(error (void-function batch-update-autoloads)) batch-update-autoloads() command-line-1(("--eval" "(setq make-backup-files nil)" "--eval" "(setq generated-autoload-file (expand-file-name \"exec-path-from-shell-autoloads.el\"))" "-f" "batch-update-autoloads" ".")) command-line() normal-top-level() Symbol’s function definition is void: batch-update-autoloads * elisp-make-autoload-file: batch-update-autoloads failed [ !! ] * ERROR: app-emacs/exec-path-from-shell-1.12::gentoo failed (compile phase): * (no error message) ``` See https://www.mail-archive.com/freebsd-pkg-fallout freebsd.org/msg1982134.html and https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-08/msg01259.html. Thanks-to: John Turner gmail.com> Signed-off-by: Sam James gentoo.org> Signed-off-by: Ulrich Müller gentoo.org> eclass/elisp-common.eclass | 1 + 1 file changed, 1 insertion(+) diff --git a/eclass/elisp-common.eclass b/eclass/elisp-common.eclass index 47c8132..2715c26 100644 --- a/eclass/elisp-common.eclass +++ b/eclass/elisp-common.eclass @@ -329,6 +329,7 @@ elisp-make-autoload-file() { EOF ${EMACS} ${EMACSFLAGS} \ + --eval "(require 'autoload)" \ --eval "(setq make-backup-files nil)" \ --eval "(setq generated-autoload-file (expand-file-name \"${f}\"))" \ -f batch-update-autoloads "${@-.}"