From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-1415766-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 5E69E158094
	for <garchives@archives.gentoo.org>; Wed,  6 Jul 2022 06:05:36 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 7F57DE0788;
	Wed,  6 Jul 2022 06:05:35 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 666BCE0788
	for <gentoo-commits@lists.gentoo.org>; Wed,  6 Jul 2022 06:05:35 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTPS id 6F872341887
	for <gentoo-commits@lists.gentoo.org>; Wed,  6 Jul 2022 06:05:34 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
	by oystercatcher.gentoo.org (Postfix) with ESMTP id E7BAB51F
	for <gentoo-commits@lists.gentoo.org>; Wed,  6 Jul 2022 06:05:32 +0000 (UTC)
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org>
Message-ID: <1657087518.c811211d3a19f9b79a9e0e9afc4aaf5e3fa5ed54.sam@gentoo>
Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/virtualbox/
X-VCS-Repository: repo/gentoo
X-VCS-Files: app-emulation/virtualbox/virtualbox-6.1.34-r4.ebuild
X-VCS-Directories: app-emulation/virtualbox/
X-VCS-Committer: sam
X-VCS-Committer-Name: Sam James
X-VCS-Revision: c811211d3a19f9b79a9e0e9afc4aaf5e3fa5ed54
X-VCS-Branch: master
Date: Wed,  6 Jul 2022 06:05:32 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-Archives-Salt: aea268e1-7d33-471d-bf85-b0a97dd9b344
X-Archives-Hash: ef64e9ffb6f98a21f1ba8648ea3dc8d5

commit:     c811211d3a19f9b79a9e0e9afc4aaf5e3fa5ed54
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Jul  6 06:04:51 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Jul  6 06:05:18 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c811211d

app-emulation/virtualbox: add more wsimport context

Bug: https://bugs.gentoo.org/832166
Signed-off-by: Sam James <sam <AT> gentoo.org>

 app-emulation/virtualbox/virtualbox-6.1.34-r4.ebuild | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/app-emulation/virtualbox/virtualbox-6.1.34-r4.ebuild b/app-emulation/virtualbox/virtualbox-6.1.34-r4.ebuild
index a20ee04a2d51..7eb42e9cf9ea 100644
--- a/app-emulation/virtualbox/virtualbox-6.1.34-r4.ebuild
+++ b/app-emulation/virtualbox/virtualbox-6.1.34-r4.ebuild
@@ -82,7 +82,13 @@ COMMON_DEPEND="
 # We're stuck on JDK (and JRE, I guess?) 1.8 because of need for wsimport
 # with USE="vboxwebsrv java". Note that we have to put things in DEPEND,
 # not (only, anyway) BDEPEND, as the eclass magic to set the environment variables
-# based on *DEPEND doesn't work for BDEPEND at least right now. See bug #832166.
+# based on *DEPEND doesn't work for BDEPEND at least right now.
+#
+# There's a comment in Config.kmk about it
+# ("With Java 11 wsimport was removed, usually part of a separate install now.")
+# but it needs more investigation.
+#
+# See bug #832166.
 DEPEND="
 	${COMMON_DEPEND}
 	alsa? ( >=media-libs/alsa-lib-1.0.13 )
@@ -550,7 +556,7 @@ src_install() {
 			eerror "(listed in PYTHON_COMPAT in the ebuild) is incomplete within the Makefiles."
 			die "Incomplete installation of Python bindings! File a bug with Gentoo!"
 		fi
-        fi
+	fi
 
 	newtmpfiles "${FILESDIR}"/${PN}-vboxusb_tmpfilesd ${PN}-vboxusb.conf
 }