From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6525A158090 for ; Tue, 24 May 2022 21:27:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4E889E07D8; Tue, 24 May 2022 21:27:23 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2C90BE07D8 for ; Tue, 24 May 2022 21:27:23 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 01D5B34188A for ; Tue, 24 May 2022 21:27:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4410E463 for ; Tue, 24 May 2022 21:27:19 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1653427562.7f296ba04cc9c825875b4d9fe5df8dbfd2971cd9.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sys-apps/pciutils/ X-VCS-Repository: repo/gentoo X-VCS-Files: sys-apps/pciutils/pciutils-3.8.0.ebuild X-VCS-Directories: sys-apps/pciutils/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 7f296ba04cc9c825875b4d9fe5df8dbfd2971cd9 X-VCS-Branch: master Date: Tue, 24 May 2022 21:27:19 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 44831a70-6d19-48b3-8755-975ca8ce68d2 X-Archives-Hash: 4253ac013b3ed7361b3065a0a682d370 commit: 7f296ba04cc9c825875b4d9fe5df8dbfd2971cd9 Author: Sam James gentoo org> AuthorDate: Tue May 24 21:26:02 2022 +0000 Commit: Sam James gentoo org> CommitDate: Tue May 24 21:26:02 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f296ba0 sys-apps/pciutils: mention why 2.37 check It's to prevent catastrophies from people running with an older Binutils in general, even if 2.35 is strictly enough (probably, not tried myself) to build this package, given older binutils can cause all sorts of problems, it should be considered a wake-up call for people running such an old one, rather than just encouraging them to bump to the lowest possible version which will work (< 2.37 is masked in Gentoo and has been for a while, and we're not backporting any fixes for it.) Bug: https://bugs.gentoo.org/802036 Signed-off-by: Sam James gentoo.org> sys-apps/pciutils/pciutils-3.8.0.ebuild | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys-apps/pciutils/pciutils-3.8.0.ebuild b/sys-apps/pciutils/pciutils-3.8.0.ebuild index e92c695e88d3..53e69aa143eb 100644 --- a/sys-apps/pciutils/pciutils-3.8.0.ebuild +++ b/sys-apps/pciutils/pciutils-3.8.0.ebuild @@ -68,6 +68,11 @@ check_binutils_version() { ver_major=$(ver_cut 1 "${ver}") ver_minor=$(ver_cut 2 "${ver}") + # We use 2.37 here, not 2.35, as https://github.com/pciutils/pciutils/issues/98 mentions + # because we've had other miscompiles with older Binutils (not just build failures!) + # and we don't want people running any unsupported versions of Binutils. An example + # of this is where glibc is completely broken with old binutils: bug #802036. It's + # just not sustainable to support. if [[ ${ver_major} -eq 2 && ${ver_minor} -lt 37 ]] ; then eerror "Old version of binutils activated! ${P} cannot be built with an old version." eerror "Please follow these steps:"