From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4E04A158090 for ; Tue, 10 May 2022 01:37:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 721EBE0864; Tue, 10 May 2022 01:37:17 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 34C95E0874 for ; Tue, 10 May 2022 01:37:17 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3DC7834150E for ; Tue, 10 May 2022 01:37:16 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C309E458 for ; Tue, 10 May 2022 01:37:14 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1652146624.db5b45315b4827253e52bbc1460ac0fbe615708c.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: www-client/seamonkey/ X-VCS-Repository: repo/gentoo X-VCS-Files: www-client/seamonkey/seamonkey-2.53.12.ebuild X-VCS-Directories: www-client/seamonkey/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: db5b45315b4827253e52bbc1460ac0fbe615708c X-VCS-Branch: master Date: Tue, 10 May 2022 01:37:14 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 5be32f27-8511-4363-a996-a94af4f1f06b X-Archives-Hash: 726f3562915b261324384ca959ad28b8 commit: db5b45315b4827253e52bbc1460ac0fbe615708c Author: Myckel Habets habets-dobben nl> AuthorDate: Sun May 8 08:23:57 2022 +0000 Commit: Sam James gentoo org> CommitDate: Tue May 10 01:37:04 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=db5b4531 www-client/seamonkey: enable elf hack on architectures that support it The old implementation, just disabled elf hack by default. Now we enable this where it is enabled by default by seamonkey itself. According to firefox this breaks with clang, so we copied over the check that firefox uses to disable it on clang builds. Bug: https://bugs.gentoo.org/836319 Signed-off-by: Myckel Habets habets-dobben.nl> Signed-off-by: Sam James gentoo.org> www-client/seamonkey/seamonkey-2.53.12.ebuild | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/www-client/seamonkey/seamonkey-2.53.12.ebuild b/www-client/seamonkey/seamonkey-2.53.12.ebuild index 4c512efa8daf..ca32eb5a0b66 100644 --- a/www-client/seamonkey/seamonkey-2.53.12.ebuild +++ b/www-client/seamonkey/seamonkey-2.53.12.ebuild @@ -393,8 +393,28 @@ src_configure() { # use startup-cache for faster startup time mozconfig_annotate '' --enable-startupcache - # Broken on some arches - mozconfig_annotate '' --disable-elf-hack + # Elf hack should be enabled by default on architectures that support it. + # On archs that don't support it, it should not be enabled by default. + # www-client/firefox says building with clang breaks elf hack on archs that + # support it, so they disable that. We assume this is the same for www-client/seamonkey. + # The code below is copied over from www-client/firefox. + if tc-is-clang ; then + # https://bugzilla.mozilla.org/show_bug.cgi?id=1482204 + # https://bugzilla.mozilla.org/show_bug.cgi?id=1483822 + # toolkit/moz.configure Elfhack section: target.cpu in ('arm', 'x86', 'x86_64') + local disable_elf_hack= + if use amd64 ; then + disable_elf_hack=yes + elif use x86 ; then + disable_elf_hack=yes + elif use arm ; then + disable_elf_hack=yes + fi + + if [[ -n ${disable_elf_hack} ]] ; then + mozconfig_annotate 'elf-hack is broken when using Clang' --disable-elf-hack + fi + fi # Disabled by default. See bug 836319 , comment 17. if ! use webrtc ; then