From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 23C8F15808D for ; Mon, 18 Apr 2022 14:17:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E0237E0936; Mon, 18 Apr 2022 14:17:06 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 32D1AE0933 for ; Mon, 18 Apr 2022 14:17:05 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 02A5434160F for ; Mon, 18 Apr 2022 14:17:04 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 6CF643B1 for ; Mon, 18 Apr 2022 14:17:02 +0000 (UTC) From: "Andreas Sturmlechner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" Message-ID: <1650291407.adf1781d4c5b1c1410675055c38465132c875237.asturm@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: kde-plasma/plasma-desktop/, kde-plasma/plasma-desktop/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: kde-plasma/plasma-desktop/files/plasma-desktop-5.24.4-folderview-icons-per-resolution.patch kde-plasma/plasma-desktop/plasma-desktop-5.24.4-r1.ebuild X-VCS-Directories: kde-plasma/plasma-desktop/files/ kde-plasma/plasma-desktop/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: adf1781d4c5b1c1410675055c38465132c875237 X-VCS-Branch: master Date: Mon, 18 Apr 2022 14:17:02 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 96d8481b-a461-4228-b96a-660176e95904 X-Archives-Hash: 6f2ce222daff9185a03afa7fb8d9549a commit: adf1781d4c5b1c1410675055c38465132c875237 Author: Andreas Sturmlechner gentoo org> AuthorDate: Mon Apr 18 13:12:11 2022 +0000 Commit: Andreas Sturmlechner gentoo org> CommitDate: Mon Apr 18 14:16:47 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=adf1781d kde-plasma/plasma-desktop: Folder View: save desktop containment icon ...positions on a per-resolution basis Upstream commit 8f85c4658adfdf7a01c591afd79baa9eed8b79dd KDE-bug: https://bugs.kde.org/show_bug.cgi?id=354802 KDE-bug: https://bugs.kde.org/show_bug.cgi?id=360478 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner gentoo.org> ...op-5.24.4-folderview-icons-per-resolution.patch | 132 +++++++++++++++ .../plasma-desktop/plasma-desktop-5.24.4-r1.ebuild | 179 +++++++++++++++++++++ 2 files changed, 311 insertions(+) diff --git a/kde-plasma/plasma-desktop/files/plasma-desktop-5.24.4-folderview-icons-per-resolution.patch b/kde-plasma/plasma-desktop/files/plasma-desktop-5.24.4-folderview-icons-per-resolution.patch new file mode 100644 index 000000000000..fce29f49536a --- /dev/null +++ b/kde-plasma/plasma-desktop/files/plasma-desktop-5.24.4-folderview-icons-per-resolution.patch @@ -0,0 +1,132 @@ +From 8f85c4658adfdf7a01c591afd79baa9eed8b79dd Mon Sep 17 00:00:00 2001 +From: Bharadwaj Raju +Date: Tue, 12 Apr 2022 15:01:15 +0000 +Subject: [PATCH] Folder View: save desktop containment icon positions on a + per-resolution basis + +BUG: 360478 +BUG: 354802 +FIXED-IN: 5.24.5 +(cherry picked from commit 2dca17060c06f85abc365bab9484ee4446d78772) +--- + .../package/contents/ui/FolderView.qml | 15 +-------- + .../package/contents/ui/FolderViewLayer.qml | 32 +++++++++++++++++-- + .../desktop/plugins/folder/positioner.cpp | 1 + + 3 files changed, 31 insertions(+), 17 deletions(-) + +diff --git a/containments/desktop/package/contents/ui/FolderView.qml b/containments/desktop/package/contents/ui/FolderView.qml +index 218a3da77..72ae4903a 100644 +--- a/containments/desktop/package/contents/ui/FolderView.qml ++++ b/containments/desktop/package/contents/ui/FolderView.qml +@@ -30,6 +30,7 @@ FocusScope { + property alias currentIndex: gridView.currentIndex + property alias url: dir.url + property alias status: dir.status ++ property alias perStripe: positioner.perStripe + property alias positions: positioner.positions + property alias errorString: dir.errorString + property alias dragging: dir.dragging +@@ -828,20 +829,6 @@ FocusScope { + } + } + +- onFlowChanged: { +- // FIXME TODO: Preserve positions. +- if (positioner.enabled) { +- positioner.reset(); +- } +- } +- +- onLayoutDirectionChanged: { +- // FIXME TODO: Preserve positions. +- if (positioner.enabled) { +- positioner.reset(); +- } +- } +- + onCurrentIndexChanged: { + positionViewAtIndex(currentIndex, GridView.Contain); + } +diff --git a/containments/desktop/package/contents/ui/FolderViewLayer.qml b/containments/desktop/package/contents/ui/FolderViewLayer.qml +index 3f9b29937..f2044e1b0 100644 +--- a/containments/desktop/package/contents/ui/FolderViewLayer.qml ++++ b/containments/desktop/package/contents/ui/FolderViewLayer.qml +@@ -29,6 +29,8 @@ FocusScope { + property alias overflowing: folderView.overflowing + property alias flow: folderView.flow + ++ property string resolution: Math.round(plasmoid.screenGeometry.width) + "x" + Math.round(plasmoid.screenGeometry.height) ++ + readonly property bool lockedByKiosk: !KAuthorized.authorize("editable_desktop_icons") + + focus: true +@@ -178,6 +180,26 @@ FocusScope { + } + } + ++ function getPositions() { ++ try { ++ var allPositions = JSON.parse(plasmoid.configuration.positions); ++ } catch (err) { ++ var allPositions = {}; ++ allPositions[resolution] = plasmoid.configuration.positions; ++ } ++ return allPositions[resolution] || ""; ++ } ++ ++ function savePositions(positions) { ++ try { ++ var allPositions = JSON.parse(plasmoid.configuration.positions); ++ } catch (err) { ++ var allPositions = {}; ++ } ++ allPositions[resolution] = positions; ++ plasmoid.configuration.positions = JSON.stringify(allPositions, Object.keys(allPositions).sort()); ++ } ++ + Connections { + target: plasmoid.configuration + +@@ -211,7 +233,7 @@ FocusScope { + } + + function onPositionsChanged() { +- folderView.positions = plasmoid.configuration.positions; ++ folderView.positions = getPositions(); + } + } + +@@ -241,12 +263,16 @@ FocusScope { + } + + onPositionsChanged: { +- plasmoid.configuration.positions = folderView.positions; ++ savePositions(folderView.positions); ++ } ++ ++ onPerStripeChanged: { ++ folderView.positions = getPositions(); + } + + Component.onCompleted: { + folderView.sortMode = plasmoid.configuration.sortMode; +- folderView.positions = plasmoid.configuration.positions; ++ folderView.positions = getPositions(); + } + } + +diff --git a/containments/desktop/plugins/folder/positioner.cpp b/containments/desktop/plugins/folder/positioner.cpp +index 859c16754..3b2df8c5a 100644 +--- a/containments/desktop/plugins/folder/positioner.cpp ++++ b/containments/desktop/plugins/folder/positioner.cpp +@@ -854,6 +854,7 @@ void Positioner::applyPositions() + } + + if (pos > m_perStripe) { ++ qDebug() << "Some items did not fit, rearranging"; + name = positions.at(offset); + + if (!sourceIndices.contains(name)) { +-- +GitLab + diff --git a/kde-plasma/plasma-desktop/plasma-desktop-5.24.4-r1.ebuild b/kde-plasma/plasma-desktop/plasma-desktop-5.24.4-r1.ebuild new file mode 100644 index 000000000000..bdd617d2cb0f --- /dev/null +++ b/kde-plasma/plasma-desktop/plasma-desktop-5.24.4-r1.ebuild @@ -0,0 +1,179 @@ +# Copyright 1999-2022 Gentoo Authors +# Distributed under the terms of the GNU General Public License v2 + +EAPI=8 + +ECM_HANDBOOK="forceoptional" +ECM_TEST="true" +KFMIN=5.90.0 +PVCUT=$(ver_cut 1-3) +QTMIN=5.15.2 +VIRTUALX_REQUIRED="test" +inherit ecm kde.org optfeature + +DESCRIPTION="KDE Plasma desktop" +XORGHDRS="${PN}-override-include-dirs-1" +SRC_URI+=" https://dev.gentoo.org/~asturm/distfiles/${XORGHDRS}.tar.xz" + +LICENSE="GPL-2" # TODO: CHECK +SLOT="5" +KEYWORDS="~amd64 ~arm ~arm64 ~ppc64 ~riscv ~x86" +IUSE="emoji ibus +kaccounts scim +semantic-desktop telemetry" + +COMMON_DEPEND=" + >=dev-qt/qtconcurrent-${QTMIN}:5 + >=dev-qt/qtdbus-${QTMIN}:5 + >=dev-qt/qtdeclarative-${QTMIN}:5 + >=dev-qt/qtgui-${QTMIN}:5 + >=dev-qt/qtnetwork-${QTMIN}:5 + >=dev-qt/qtprintsupport-${QTMIN}:5 + >=dev-qt/qtsql-${QTMIN}:5 + >=dev-qt/qtsvg-${QTMIN}:5 + >=dev-qt/qtwidgets-${QTMIN}:5 + >=dev-qt/qtx11extras-${QTMIN}:5 + >=dev-qt/qtxml-${QTMIN}:5 + >=kde-frameworks/attica-${KFMIN}:5 + >=kde-frameworks/kactivities-${KFMIN}:5 + >=kde-frameworks/kactivities-stats-${KFMIN}:5 + >=kde-frameworks/karchive-${KFMIN}:5 + >=kde-frameworks/kauth-${KFMIN}:5 + >=kde-frameworks/kbookmarks-${KFMIN}:5 + >=kde-frameworks/kcmutils-${KFMIN}:5 + >=kde-frameworks/kcodecs-${KFMIN}:5 + >=kde-frameworks/kcompletion-${KFMIN}:5 + >=kde-frameworks/kconfig-${KFMIN}:5 + >=kde-frameworks/kconfigwidgets-${KFMIN}:5 + >=kde-frameworks/kcoreaddons-${KFMIN}:5 + >=kde-frameworks/kcrash-${KFMIN}:5 + >=kde-frameworks/kdbusaddons-${KFMIN}:5 + >=kde-frameworks/kdeclarative-${KFMIN}:5 + >=kde-frameworks/kded-${KFMIN}:5 + >=kde-frameworks/kdelibs4support-${KFMIN}:5 + >=kde-frameworks/kglobalaccel-${KFMIN}:5 + >=kde-frameworks/kguiaddons-${KFMIN}:5 + >=kde-frameworks/ki18n-${KFMIN}:5 + >=kde-frameworks/kiconthemes-${KFMIN}:5 + >=kde-frameworks/kio-${KFMIN}:5 + >=kde-frameworks/kitemmodels-${KFMIN}:5 + >=kde-frameworks/kitemviews-${KFMIN}:5 + >=kde-frameworks/kjobwidgets-${KFMIN}:5 + >=kde-frameworks/knewstuff-${KFMIN}:5 + >=kde-frameworks/knotifications-${KFMIN}:5 + >=kde-frameworks/knotifyconfig-${KFMIN}:5 + >=kde-frameworks/kparts-${KFMIN}:5 + >=kde-frameworks/krunner-${KFMIN}:5 + >=kde-frameworks/kservice-${KFMIN}:5 + >=kde-frameworks/kwidgetsaddons-${KFMIN}:5 + >=kde-frameworks/kwindowsystem-${KFMIN}:5 + >=kde-frameworks/kxmlgui-${KFMIN}:5 + >=kde-frameworks/plasma-${KFMIN}:5 + >=kde-frameworks/solid-${KFMIN}:5 + >=kde-frameworks/sonnet-${KFMIN}:5 + >=kde-plasma/kwin-${PVCUT}:5 + >=kde-plasma/libksysguard-${PVCUT}:5 + >=kde-plasma/libkworkspace-${PVCUT}:5 + >=kde-plasma/plasma-workspace-${PVCUT}:5 + >=media-libs/phonon-4.11.0 + x11-libs/libX11 + x11-libs/libXfixes + x11-libs/libXi + x11-libs/libxcb[xkb] + x11-libs/libxkbfile + emoji? ( + app-i18n/ibus[emoji] + dev-libs/glib:2 + media-fonts/noto-emoji + ) + ibus? ( + app-i18n/ibus + dev-libs/glib:2 + >=dev-qt/qtx11extras-${QTMIN}:5 + x11-libs/libxcb + x11-libs/xcb-util-keysyms + ) + kaccounts? ( + kde-apps/kaccounts-integration:5 + net-libs/accounts-qt + ) + scim? ( app-i18n/scim ) + semantic-desktop? ( >=kde-frameworks/baloo-${KFMIN}:5 ) + telemetry? ( dev-libs/kuserfeedback:5 ) +" +DEPEND="${COMMON_DEPEND} + dev-libs/boost + x11-base/xorg-proto +" +RDEPEND="${COMMON_DEPEND} + !kde-plasma/user-manager + >=dev-qt/qtgraphicaleffects-${QTMIN}:5 + >=dev-qt/qtquickcontrols2-${QTMIN}:5 + >=kde-frameworks/kirigami-${KFMIN}:5 + >=kde-frameworks/qqc2-desktop-style-${KFMIN}:5 + >=kde-plasma/kde-cli-tools-${PVCUT}:5 + >=kde-plasma/oxygen-${PVCUT}:5 + sys-apps/util-linux + x11-apps/setxkbmap + x11-misc/xdg-user-dirs + kaccounts? ( net-libs/signon-oauth2 ) +" +BDEPEND="virtual/pkgconfig" + +PATCHES=( + "${WORKDIR}/${XORGHDRS}/override-include-dirs.patch" # downstream patch + "${FILESDIR}/${P}-folderview-icons-per-resolution.patch" # KDE-bug 354802, 360478 +) + +src_prepare() { + ecm_src_prepare + + if ! use ibus; then + sed -e "s/Qt5X11Extras_FOUND AND XCB_XCB_FOUND AND XCB_KEYSYMS_FOUND/false/" \ + -i applets/kimpanel/backend/ibus/CMakeLists.txt || die + fi + + use emoji || cmake_run_in applets/kimpanel/backend/ibus \ + cmake_comment_add_subdirectory emojier + + # TODO: try to get a build switch upstreamed + if ! use scim; then + sed -e "s/^pkg_check_modules.*SCIM/#&/" -i CMakeLists.txt || die + fi +} + +src_configure() { + local mycmakeargs=( + -DCMAKE_DISABLE_FIND_PACKAGE_PackageKitQt5=ON # not packaged + -DEVDEV_INCLUDE_DIRS="${WORKDIR}/${XORGHDRS}"/include + -DXORGLIBINPUT_INCLUDE_DIRS="${WORKDIR}/${XORGHDRS}"/include + -DXORGSERVER_INCLUDE_DIRS="${WORKDIR}/${XORGHDRS}"/include + -DSYNAPTICS_INCLUDE_DIRS="${WORKDIR}/${XORGHDRS}"/include + $(cmake_use_find_package kaccounts AccountsQt5) + $(cmake_use_find_package kaccounts KAccounts) + $(cmake_use_find_package semantic-desktop KF5Baloo) + $(cmake_use_find_package telemetry KUserFeedback) + ) + if ! use emoji && ! use ibus; then + mycmakeargs+=( -DCMAKE_DISABLE_FIND_PACKAGE_GLIB2=ON ) + fi + + ecm_src_configure +} + +src_test() { + # parallel tests fail, foldermodeltest,positionertest hang, bug #646890 + # test_kio_fonts needs D-Bus, bug #634166 + # lookandfeel-kcmTest is unreliable for a long time, bug #607918 + local myctestargs=( + -j1 + -E "(foldermodeltest|positionertest|test_kio_fonts|lookandfeel-kcmTest)" + ) + + ecm_src_test +} + +pkg_postinst() { + if [[ -z "${REPLACING_VERSIONS}" ]]; then + optfeature "screen reader support" app-accessibility/orca + fi + ecm_pkg_postinst +}