From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BD91615808B for ; Tue, 12 Apr 2022 02:00:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B9251E0896; Tue, 12 Apr 2022 02:00:12 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B84E9E089A for ; Tue, 12 Apr 2022 02:00:11 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 6ECA1341B12 for ; Tue, 12 Apr 2022 02:00:10 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C4DD5398 for ; Tue, 12 Apr 2022 02:00:08 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1649728792.0d74ce0945f0567d2c695fe4443a5c94046dfe09.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/ X-VCS-Repository: proj/portage X-VCS-Files: bin/install-qa-check.d/60pkgconfig X-VCS-Directories: bin/install-qa-check.d/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 0d74ce0945f0567d2c695fe4443a5c94046dfe09 X-VCS-Branch: master Date: Tue, 12 Apr 2022 02:00:08 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 166f6fe8-2b0b-4a10-9436-04a3ed54cb00 X-Archives-Hash: ecb92070055070d9848bc8ea9d0b157f commit: 0d74ce0945f0567d2c695fe4443a5c94046dfe09 Author: Sam James gentoo org> AuthorDate: Thu Oct 28 00:37:15 2021 +0000 Commit: Sam James gentoo org> CommitDate: Tue Apr 12 01:59:52 2022 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=0d74ce09 install-qa-check.d/60pkgconfig: run pkg-config --validate on installed files Similar to the XDG desktop file validation check. Signed-off-by: Sam James gentoo.org> bin/install-qa-check.d/60pkgconfig | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/bin/install-qa-check.d/60pkgconfig b/bin/install-qa-check.d/60pkgconfig index 2cc9f7c59..9c4768a95 100644 --- a/bin/install-qa-check.d/60pkgconfig +++ b/bin/install-qa-check.d/60pkgconfig @@ -16,6 +16,16 @@ pkgconfig_check() { eqawarn "QA Notice: pkg-config files with wrong LDFLAGS detected:" eqawarn "${f//${D}}" fi + + # Validate using pkgconfig + # Some less common implementations may not support this? + # seems like f.d.o, OpenBSD, and of course pkgconf do though. + # Need --maximum-traverse-depth=1 to avoid checking deps and giving + # unrelated warnings/errors. + if ! pkg-config --maximum-traverse-depth=1 --validate "${files[@]}" ; then + eqawarn "QA Notice: pkg-config files which fail validation found!" + eqawarn "Run 'pkg-config --validate ...' for more information" + fi } pkgconfig_check