From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8268B15808B for ; Mon, 28 Mar 2022 19:31:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 73793E0924; Mon, 28 Mar 2022 19:31:56 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4D6C1E0924 for ; Mon, 28 Mar 2022 19:31:55 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E3DFC335D99 for ; Mon, 28 Mar 2022 19:31:53 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4CB03343 for ; Mon, 28 Mar 2022 19:31:52 +0000 (UTC) From: "Lars Wendler" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Lars Wendler" Message-ID: <1648495894.8aeeba04d1e08aa74cf50e402eb37477e402ec33.polynomial-c@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sys-libs/liburing/ X-VCS-Repository: repo/gentoo X-VCS-Files: sys-libs/liburing/liburing-2.1-r1.ebuild sys-libs/liburing/liburing-2.1-r2.ebuild sys-libs/liburing/liburing-9999.ebuild X-VCS-Directories: sys-libs/liburing/ X-VCS-Committer: polynomial-c X-VCS-Committer-Name: Lars Wendler X-VCS-Revision: 8aeeba04d1e08aa74cf50e402eb37477e402ec33 X-VCS-Branch: master Date: Mon, 28 Mar 2022 19:31:52 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 80fb5b49-6220-4b40-8918-dd314405e269 X-Archives-Hash: b59f7d569e336b30243e06eb4dee1b0e commit: 8aeeba04d1e08aa74cf50e402eb37477e402ec33 Author: Jeremi Piotrowski microsoft com> AuthorDate: Thu Mar 24 11:17:22 2022 +0000 Commit: Lars Wendler gentoo org> CommitDate: Mon Mar 28 19:31:34 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8aeeba04 sys-libs/liburing: pass --cxx paramter to configure Provide the correct value to --cxx to fix cross-compilation. liburing uses the value of the cxx variable for linking. This happens to work for native builds but breaks when cross-compiling, as evidenced by the below output (from Flatcar): >>> Configuring source in /build/arm64-usr/var/tmp/portage/sys-libs/liburing-2.1-r1/work/liburing-2.1 ... * .arm64: running multilib-minimal_abi_src_configure prefix /usr includedir /usr/include libdir /usr/lib64 libdevdir /usr/lib64 relativelibdir mandir /usr/share/man datadir /usr/share stringop_overflow yes array_bounds yes __kernel_rwf_t yes __kernel_timespec yes open_how no statx yes C++ yes has_ucontext yes CC aarch64-cros-linux-gnu-gcc CXX g++ ... aarch64-cros-linux-gnu-gcc -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -O2 -pipe -mtune=generic -g -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -o statx statx.c helpers.o -luring -Wstringop-overflow=0 -Warray-bounds=0 g++ -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -O2 -pipe -mtune=generic -g -O2 -pipe -mtune=generic -g -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -std=c++11 -o sq-full-cpp sq-full-cpp.cc helpers.o -luring -Wstringop-overflow=0 -Warray-bounds=0 /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183) /usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: error adding symbols: file in wrong format collect2: error: ld returned 1 exit status make[1]: *** [Makefile:165: sq-full-cpp] Error 1 make[1]: *** Waiting for unfinished jobs.... Bug: https://bugs.gentoo.org/836316 Signed-off-by: Jeremi Piotrowski microsoft.com> Closes: https://github.com/gentoo/gentoo/pull/24733 Signed-off-by: Lars Wendler gentoo.org> sys-libs/liburing/liburing-2.1-r1.ebuild | 1 + sys-libs/liburing/liburing-2.1-r2.ebuild | 1 + sys-libs/liburing/liburing-9999.ebuild | 1 + 3 files changed, 3 insertions(+) diff --git a/sys-libs/liburing/liburing-2.1-r1.ebuild b/sys-libs/liburing/liburing-2.1-r1.ebuild index ae14b067cbb3..ddf39035944f 100644 --- a/sys-libs/liburing/liburing-2.1-r1.ebuild +++ b/sys-libs/liburing/liburing-2.1-r1.ebuild @@ -45,6 +45,7 @@ multilib_src_configure() { --libdevdir="${EPREFIX}/usr/$(get_libdir)" --mandir="${EPREFIX}/usr/share/man" --cc="$(tc-getCC)" + --cxx="$(tc-getCXX)" ) # No autotools configure! "econf" will fail. TMPDIR="${T}" ./configure "${myconf[@]}" diff --git a/sys-libs/liburing/liburing-2.1-r2.ebuild b/sys-libs/liburing/liburing-2.1-r2.ebuild index c65e7baf841c..cb5271810e69 100644 --- a/sys-libs/liburing/liburing-2.1-r2.ebuild +++ b/sys-libs/liburing/liburing-2.1-r2.ebuild @@ -51,6 +51,7 @@ multilib_src_configure() { --libdevdir="${EPREFIX}/usr/$(get_libdir)" --mandir="${EPREFIX}/usr/share/man" --cc="$(tc-getCC)" + --cxx="$(tc-getCXX)" ) # No autotools configure! "econf" will fail. TMPDIR="${T}" ./configure "${myconf[@]}" diff --git a/sys-libs/liburing/liburing-9999.ebuild b/sys-libs/liburing/liburing-9999.ebuild index c7427bfe9a0d..87e93eac4554 100644 --- a/sys-libs/liburing/liburing-9999.ebuild +++ b/sys-libs/liburing/liburing-9999.ebuild @@ -40,6 +40,7 @@ multilib_src_configure() { --libdevdir="${EPREFIX}/usr/$(get_libdir)" --mandir="${EPREFIX}/usr/share/man" --cc="$(tc-getCC)" + --cxx="$(tc-getCXX)" ) # No autotools configure! "econf" will fail. TMPDIR="${T}" ./configure "${myconf[@]}"