From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: quickstart/
Date: Thu, 9 Dec 2021 04:12:48 +0000 (UTC) [thread overview]
Message-ID: <1639023131.22633c2132444e7398db9d6de3fcfdd6e4cf4639.sam@gentoo> (raw)
commit: 22633c2132444e7398db9d6de3fcfdd6e4cf4639
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Dec 9 04:12:11 2021 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Dec 9 04:12:11 2021 +0000
URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=22633c21
quickstart: mention PATCHES, use .patch and not .diff
- We expect contributions to use .patch and not .diff nowadays.
- Mention PATCHES so people are aware it's an option.
Signed-off-by: Sam James <sam <AT> gentoo.org>
quickstart/text.xml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/quickstart/text.xml b/quickstart/text.xml
index fb9461e..caff4e5 100644
--- a/quickstart/text.xml
+++ b/quickstart/text.xml
@@ -257,8 +257,9 @@ for some more complex examples.
<body>
<p>
-Often we need to apply patches. This is done in the <c>src_prepare</c>
-function using the <c>eapply</c> helper function. To use <c>eapply</c>
+Often we need to apply patches. This is done either by defining the
+<c>PATCHES</c> array in global scope or in the <c>src_prepare</c> function
+using the <c>eapply</c> helper function. To use <c>eapply</c>,
one must use EAPI 7. Here's <c>app-misc/detox/detox-1.1.0.ebuild</c>:
</p>
@@ -266,7 +267,7 @@ one must use EAPI 7. Here's <c>app-misc/detox/detox-1.1.0.ebuild</c>:
# Copyright 1999-2021 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
-EAPI=7
+EAPI=8
DESCRIPTION="detox safely removes spaces and strange characters from filenames"
HOMEPAGE="http://detox.sourceforge.net/"
@@ -387,11 +388,10 @@ DEPEND="${RDEPEND}"
BDEPEND="dev-util/pkgconfig
nls? ( >=sys-devel/gettext-0.12.1 )"
-src_prepare() {
- eapply "${FILESDIR}"/${PN}-namespace.diff \
- "${FILESDIR}"/${PN}-procmime.diff
- eapply_user
-}
+PATCHES=(
+ "${FILESDIR}"/${PN}-namespace.patch
+ "${FILESDIR}"/${PN}-procmime.patch
+)
src_configure() {
econf \
next reply other threads:[~2021-12-09 4:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 4:12 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-18 2:07 [gentoo-commits] proj/devmanual:master commit in: quickstart/ Sam James
2022-03-13 1:47 Sam James
2021-12-09 4:09 Sam James
2021-12-09 4:08 Sam James
2021-12-09 4:08 Sam James
2020-02-16 18:05 Ulrich Müller
2020-01-23 13:50 Ulrich Müller
2019-11-26 3:05 Göktürk Yüksek
2019-11-26 1:49 Göktürk Yüksek
2019-05-13 18:52 Ulrich Müller
2019-05-13 18:52 Ulrich Müller
2019-05-13 18:52 Ulrich Müller
2018-10-24 17:49 Brian Evans
2018-06-14 18:43 Göktürk Yüksek
2016-10-28 14:41 Göktürk Yüksek
2015-08-09 12:39 Justin Lecher
2015-08-09 12:39 Justin Lecher
2013-01-21 8:18 Pacho Ramos
2012-10-12 17:44 Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1639023131.22633c2132444e7398db9d6de3fcfdd6e4cf4639.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox