From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 53B2A158F6D for ; Mon, 16 Aug 2021 20:48:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3A1DAE0A03; Mon, 16 Aug 2021 02:12:23 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 216F3E0A03 for ; Mon, 16 Aug 2021 02:12:23 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A22413458BD for ; Mon, 16 Aug 2021 02:12:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 426B18B0 for ; Mon, 16 Aug 2021 02:12:20 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1629079928.28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: metadata/install-qa-check.d/ X-VCS-Repository: repo/gentoo X-VCS-Files: metadata/install-qa-check.d/60tmpfiles-paths X-VCS-Directories: metadata/install-qa-check.d/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb X-VCS-Branch: master Date: Mon, 16 Aug 2021 02:12:20 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: e5e18a25-6a93-4ee1-b120-e00175266f7c X-Archives-Hash: 4ba27955ee36a3ccf2d9eb285d40f6e2 commit: 28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb Author: Sam James gentoo org> AuthorDate: Fri Aug 13 01:42:46 2021 +0000 Commit: Sam James gentoo org> CommitDate: Mon Aug 16 02:12:08 2021 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28155dfc metadata/install-qa-check.d: add exemptions for some packages wrt inherit Both sys-apps/systemd and sys-libs/pam need to install some files to these directories without inheriting the eclass. For future work, we should have a standardised way on opting out of installed files QA checks, but other QA checks are already suffering from this issue. See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b Signed-off-by: Sam James gentoo.org> metadata/install-qa-check.d/60tmpfiles-paths | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/metadata/install-qa-check.d/60tmpfiles-paths b/metadata/install-qa-check.d/60tmpfiles-paths index 5ef56885ebe..81286de584a 100644 --- a/metadata/install-qa-check.d/60tmpfiles-paths +++ b/metadata/install-qa-check.d/60tmpfiles-paths @@ -30,6 +30,14 @@ tmpfiles_check() { return fi + # It's okay for some packages to do this because of circular dependencies and such + # See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b + # TODO: Standardize some way of allowing ebuilds to opt-out of checks like this + local package=${CATEGORY}/${PN} + if [[ ${package} == "sys-apps/systemd" || ${package} == "sys-libs/pam" ]] ; then + return + fi + if [[ -d "${ED}"/usr/lib/tmpfiles.d/ ]] ; then eqawarn "QA Notice: package is installing tmpfiles without inheriting tmpfiles.eclass!" eqawarn "Packages must inherit tmpfiles.eclass then call tmpfiles_process in pkg_postinst."