public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "William Breathitt Gray" <vilhelm.gray@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/proj/guru:dev commit in: games-fps/crispy-doom/
Date: Wed, 11 Aug 2021 00:04:48 +0000 (UTC)	[thread overview]
Message-ID: <1628640249.05fbaf103daecf4746af40048f2c2426ef662b4e.vilhelm.gray@gentoo> (raw)

commit:     05fbaf103daecf4746af40048f2c2426ef662b4e
Author:     William Breathitt Gray <vilhelm.gray <AT> gmail <DOT> com>
AuthorDate: Wed Aug 11 00:04:09 2021 +0000
Commit:     William Breathitt Gray <vilhelm.gray <AT> gmail <DOT> com>
CommitDate: Wed Aug 11 00:04:09 2021 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=05fbaf10

games-fps/crispy-doom: [QA] unconditionally install completion files

QA policy [0] says that we don't conditionalise installation of
small files. It's a wasteful rebuild and inconsistent across packages
for when users desire completions to be available.

[0] https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301
Signed-off-by: William Breathitt Gray <vilhelm.gray <AT> gmail.com>

 games-fps/crispy-doom/crispy-doom-5.10.2.ebuild | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild b/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild
index 5f559378a..506534c2e 100644
--- a/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild
+++ b/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild
@@ -14,7 +14,7 @@ SRC_URI="https://github.com/fabiangreffrath/${PN}/archive/${P}.tar.gz"
 LICENSE="BSD GPL-2+"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="bash-completion doc libsamplerate +midi png truecolor vorbis zlib"
+IUSE="doc libsamplerate +midi png truecolor vorbis zlib"
 
 DEPEND="
 	media-libs/libsdl2[video]
@@ -24,8 +24,9 @@ DEPEND="
 	png? ( media-libs/libpng:= )
 	zlib? ( sys-libs/zlib )"
 RDEPEND="${DEPEND}"
+# ${PYTHON_DEPS} for bash-completion
 BDEPEND="
-	bash-completion? ( ${PYTHON_DEPS} )
+	${PYTHON_DEPS}
 	doc? ( ${PYTHON_DEPS} )"
 
 S="${WORKDIR}"/${PN}-${P}
@@ -51,7 +52,7 @@ src_prepare() {
 
 src_configure() {
 	econf \
-		$(use_enable bash-completion) \
+		--enable-bash-completion \
 		$(use_enable doc) \
 		--disable-fonts \
 		--disable-icons \


             reply	other threads:[~2021-08-11  0:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  0:04 William Breathitt Gray [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-05-15 12:45 [gentoo-commits] repo/proj/guru:master commit in: games-fps/crispy-doom/ Julien Roy
2024-05-15 12:41 ` [gentoo-commits] repo/proj/guru:dev " Julien Roy
2024-05-15  0:45 Julien Roy
2023-04-02 13:35 William Breathitt Gray
2023-02-26 18:05 William Breathitt Gray
2022-09-08 16:17 William Breathitt Gray
2022-02-12  8:56 William Breathitt Gray
2021-08-17 22:52 William Breathitt Gray
2021-08-10 12:26 William Breathitt Gray
2021-05-25  8:10 Anna Vyalkova
2021-03-24 23:49 William Breathitt Gray
2021-01-12 10:01 William Breathitt Gray
2020-09-22 12:42 William Breathitt Gray
2020-09-04 12:52 William Breathitt Gray
2020-08-19 12:37 William Breathitt Gray
2020-05-12 14:08 William Breathitt Gray
2020-04-12 16:16 Andrew Ammerlaan
2020-03-13 14:34 Andrew Ammerlaan
2019-06-11 10:08 William Breathitt Gray
2019-05-21  2:21 William Breathitt Gray
2019-05-18  9:16 William Breathitt Gray
2019-05-18  8:55 William Breathitt Gray
2019-05-17  7:54 William Breathitt Gray
2019-05-16  2:31 William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628640249.05fbaf103daecf4746af40048f2c2426ef662b4e.vilhelm.gray@gentoo \
    --to=vilhelm.gray@gmail.com \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox