public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Mike Gilbert" <floppym@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: x11-apps/xdm/
Date: Mon,  5 Apr 2021 02:04:24 +0000 (UTC)	[thread overview]
Message-ID: <1617588181.754e286bf1a5fdd6cf9d6be4cbbb3779dbd7559b.floppym@gentoo> (raw)

commit:     754e286bf1a5fdd6cf9d6be4cbbb3779dbd7559b
Author:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
AuthorDate: Mon Apr  5 02:03:01 2021 +0000
Commit:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
CommitDate: Mon Apr  5 02:03:01 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=754e286b

x11-apps/xdm: avoid using FILESDIR in pkg_setup

Defining PATCHES and configure flags in pkg_setup is weird.
Move them to src_prepare and src_configure, respectively.

Signed-off-by: Mike Gilbert <floppym <AT> gentoo.org>

 x11-apps/xdm/xdm-1.1.12.ebuild | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/x11-apps/xdm/xdm-1.1.12.ebuild b/x11-apps/xdm/xdm-1.1.12.ebuild
index 5f1478118b5..1199ae27622 100644
--- a/x11-apps/xdm/xdm-1.1.12.ebuild
+++ b/x11-apps/xdm/xdm-1.1.12.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
@@ -37,13 +37,25 @@ RDEPEND="
 DEPEND="${RDEPEND}
 	x11-base/xorg-proto"
 
-pkg_setup() {
-	PATCHES=(
+src_prepare() {
+	local PATCHES=(
 		"${FILESDIR}"/${P}-consolekit.patch # bug 747124
 		"${FILESDIR}"/${P}-make-xinerama-optional.patch
 	)
 
-	XORG_CONFIGURE_OPTIONS=(
+	sed -i -e 's:^Alias=.*$:Alias=display-manager.service:' \
+		xdm.service.in || die
+
+	# Disable XDM-AUTHORIZATION-1 (bug #445662).
+	# it causes issue with libreoffice and SDL games (bug #306223).
+	sed -i -e '/authorize/a DisplayManager*authName:	MIT-MAGIC-COOKIE-1' \
+			config/xdm-config.in || die
+
+	xorg-3_src_prepare
+}
+
+src_configure() {
+	local XORG_CONFIGURE_OPTIONS=(
 		$(use_enable ipv6)
 		$(use_with pam)
 		$(use_with systemd systemd-daemon)
@@ -54,18 +66,7 @@ pkg_setup() {
 		--with-default-vt=${DEFAULTVT}
 		--with-xdmconfigdir=/etc/X11/xdm
 	)
-}
-
-src_prepare() {
-	sed -i -e 's:^Alias=.*$:Alias=display-manager.service:' \
-		xdm.service.in || die
-
-	# Disable XDM-AUTHORIZATION-1 (bug #445662).
-	# it causes issue with libreoffice and SDL games (bug #306223).
-	sed -i -e '/authorize/a DisplayManager*authName:	MIT-MAGIC-COOKIE-1' \
-			config/xdm-config.in || die
-
-	xorg-3_src_prepare
+	xorg-3_src_configure
 }
 
 src_install() {


             reply	other threads:[~2021-04-05  2:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05  2:04 Mike Gilbert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-04-14  3:45 [gentoo-commits] repo/gentoo:master commit in: x11-apps/xdm/ Matt Turner
2025-04-10  4:46 Arthur Zamarin
2025-04-10  0:12 Sam James
2025-04-09 22:38 Sam James
2025-04-09 22:38 Sam James
2025-04-09 22:38 Sam James
2025-04-09 22:38 Sam James
2025-04-09 22:38 Sam James
2025-03-10 19:02 Matt Turner
2024-05-05  9:33 Sam James
2024-05-05  9:33 Sam James
2024-05-05  9:33 Sam James
2024-05-05  9:33 Sam James
2024-05-05  8:18 Sam James
2024-05-05  8:18 Sam James
2024-05-05  8:18 Sam James
2024-04-21 21:09 Matt Turner
2024-04-05  1:20 Matt Turner
2024-03-23 23:58 Matt Turner
2024-01-24 17:00 Matt Turner
2024-01-23 16:40 Sam James
2024-01-14 20:17 Sam James
2024-01-14 20:17 Sam James
2024-01-14 20:17 Sam James
2024-01-14 20:17 Sam James
2024-01-14 19:53 Arthur Zamarin
2024-01-14 19:53 Arthur Zamarin
2023-01-24 18:29 Arthur Zamarin
2022-12-03 23:49 Matt Turner
2022-05-28  1:35 Sam James
2022-05-25 18:00 Jakov Smolić
2022-05-25 17:57 Jakov Smolić
2022-05-08 23:01 Sam James
2022-05-07 17:55 Jakov Smolić
2022-04-04  3:01 Matt Turner
2022-01-21 12:42 Sam James
2022-01-09  9:46 James Le Cuirot
2021-09-22  8:29 Yixun Lan
2021-06-22 22:38 Sam James
2020-10-09  5:54 Mikle Kolyada
2020-10-07 17:40 Mikle Kolyada
2020-10-06 17:47 Mikle Kolyada
2020-03-11 18:42 Matt Turner
2019-10-12 18:11 Mikle Kolyada
2019-05-03 20:30 Sergei Trofimovich
2019-03-03 17:55 Matt Turner
2016-03-13 15:09 Manuel Rüger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617588181.754e286bf1a5fdd6cf9d6be4cbbb3779dbd7559b.floppym@gentoo \
    --to=floppym@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox