From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 591911382C5 for ; Mon, 28 Dec 2020 19:12:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A5F41E0B09; Mon, 28 Dec 2020 19:12:27 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8BC0FE0B09 for ; Mon, 28 Dec 2020 19:12:26 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4AB5834129F for ; Mon, 28 Dec 2020 19:12:25 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id CCDFB49 for ; Mon, 28 Dec 2020 19:12:23 +0000 (UTC) From: "Michael Orlitzky" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michael Orlitzky" Message-ID: <1609182535.6f8585de7ea586a36cbc06530346f855540d25e0.mjo@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: mail-filter/opendkim/ X-VCS-Repository: repo/gentoo X-VCS-Files: mail-filter/opendkim/opendkim-2.10.3-r25.ebuild mail-filter/opendkim/opendkim-2.10.3-r26.ebuild X-VCS-Directories: mail-filter/opendkim/ X-VCS-Committer: mjo X-VCS-Committer-Name: Michael Orlitzky X-VCS-Revision: 6f8585de7ea586a36cbc06530346f855540d25e0 X-VCS-Branch: master Date: Mon, 28 Dec 2020 19:12:23 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 1930f1af-fd94-4afa-8401-767932545d56 X-Archives-Hash: 553e50cecc6acb0b5cb6888db7a5902b commit: 6f8585de7ea586a36cbc06530346f855540d25e0 Author: Michael Orlitzky gentoo org> AuthorDate: Mon Dec 28 19:08:38 2020 +0000 Commit: Michael Orlitzky gentoo org> CommitDate: Mon Dec 28 19:08:55 2020 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f8585de mail-filter/opendkim: new revision to disable parallel tests. The test suite for OpenDKIM currently relies on two "setup" and "cleanup" tests being run at the beginning/end of the test suite, respectively. But when the test suite is run in parallel, that's not always guaranteed. This new revision runs the test suite sequentially to avoid the problem, which has been reported upstream. The credit for this goes to klondike, who was able to determine the root cause of the heisenbug. In the process, a minor security vulnerability (insecure /tmp path) was also reported upstream and fixed in the ebuild. Closes: https://bugs.gentoo.org/745969 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Michael Orlitzky gentoo.org> ...ndkim-2.10.3-r25.ebuild => opendkim-2.10.3-r26.ebuild} | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/mail-filter/opendkim/opendkim-2.10.3-r25.ebuild b/mail-filter/opendkim/opendkim-2.10.3-r26.ebuild similarity index 93% rename from mail-filter/opendkim/opendkim-2.10.3-r25.ebuild rename to mail-filter/opendkim/opendkim-2.10.3-r26.ebuild index b105074a89a..5aad117eed3 100644 --- a/mail-filter/opendkim/opendkim-2.10.3-r25.ebuild +++ b/mail-filter/opendkim/opendkim-2.10.3-r26.ebuild @@ -68,6 +68,15 @@ src_prepare() { sed -e 's:dist_doc_DATA:dist_html_DATA:' \ -i libopendkim/docs/Makefile.am \ || die + + # The existing hard-coded path under /tmp is vulnerable to exploits + # since (for example) a user can create a symlink there to a file + # that portage will clobber. Reported upstream at, + # + # https://github.com/trusteddomainproject/OpenDKIM/issues/113 + # + sed -e "s:/tmp:${T}:" -i libopendkim/tests/t-testdata.h || die + eautoreconf } @@ -121,6 +130,12 @@ src_compile() { emake runstatedir=/run } +src_test() { + # Needed for now due to the expected sequencing of the setup/cleanup + # tests, https://github.com/trusteddomainproject/OpenDKIM/issues/110 + emake -j1 check +} + src_install() { default find "${D}" -name '*.la' -type f -delete || die