public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Lars Wendler" <polynomial-c@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/apache:master commit in: 2.4/init/
Date: Tue,  1 Dec 2020 12:19:58 +0000 (UTC)	[thread overview]
Message-ID: <1606824760.db9bc13b034e1dcca1765dbf0e2a7efcc1b6d3ba.polynomial-c@gentoo> (raw)

commit:     db9bc13b034e1dcca1765dbf0e2a7efcc1b6d3ba
Author:     Lars Wendler <polynomial-c <AT> gentoo <DOT> org>
AuthorDate: Tue Dec  1 12:07:58 2020 +0000
Commit:     Lars Wendler <polynomial-c <AT> gentoo <DOT> org>
CommitDate: Tue Dec  1 12:12:40 2020 +0000
URL:        https://gitweb.gentoo.org/proj/apache.git/commit/?id=db9bc13b

2.4/init: Attempt to provide a way to no longer "need net" in depend

Code blatantly stolen from net-misc/openssh init script

Bug: https://bugs.gentoo.org/482092
Signed-off-by: Lars Wendler <polynomial-c <AT> gentoo.org>

 2.4/init/apache2.initd | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/2.4/init/apache2.initd b/2.4/init/apache2.initd
index b0be24a..941dad9 100755
--- a/2.4/init/apache2.initd
+++ b/2.4/init/apache2.initd
@@ -33,9 +33,24 @@ APACHE2_OPTS="${APACHE2_OPTS} -f ${CONFIGFILE}"
 APACHE2="/usr/sbin/apache2"
 
 depend() {
-	need net
 	use dns entropy logger mysql netmount postgresql
 	after sshd
+	if ! echo ${rc_need} | grep -Fq "net." ; then
+		local x warn_addr
+		for x in $(virtualhosts | grep '^\(\[\|\)[[:digit:]]' | sed 's@\(:[[:digit:]]\{1,5\}\)\([[:space:]].*\|$\)@\1@' | sort -u) ; do
+			case "${x}" in
+				\*:80|\*.443) ;;
+				*) warn_addr="${warn_addr} ${x}" ;;
+			esac
+		done
+		if [ -n "${warn_addr}" ] ; then
+			need net
+			ewarn "You are binding an interface in you virtual hosts."
+			ewarn "You must add rc_need=\"net.FOO\" to your ${RC_PREFIX%/}/etc/conf.d/apache2"
+			ewarn "where FOO is the interface(s) providing the following address(es):"
+			ewarn "${warn_addr}"
+		fi
+	fi
 }
 
 configtest() {


             reply	other threads:[~2020-12-01 12:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 12:19 Lars Wendler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-23 10:19 [gentoo-commits] proj/apache:master commit in: 2.4/init/ Hans de Graaff
2023-09-03  7:40 Hans de Graaff
2020-12-30  1:46 Lars Wendler
2020-12-30  1:32 Lars Wendler
2020-12-03 16:06 Lars Wendler
2020-12-02 11:43 Lars Wendler
2020-12-01 12:35 Lars Wendler
2018-03-23 16:22 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2016-03-03 13:03 Lars Wendler
2014-05-14 13:56 Lars Wendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1606824760.db9bc13b034e1dcca1765dbf0e2a7efcc1b6d3ba.polynomial-c@gentoo \
    --to=polynomial-c@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox