public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Joonas Niilola" <juippis@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: net-misc/dahdi/
Date: Thu, 25 Jun 2020 11:18:33 +0000 (UTC)	[thread overview]
Message-ID: <1593083903.e218181a346d02f68e92267d94f299319104d3b6.juippis@gentoo> (raw)

commit:     e218181a346d02f68e92267d94f299319104d3b6
Author:     Jaco Kroon <jaco <AT> uls <DOT> co <DOT> za>
AuthorDate: Thu Jun 11 19:59:13 2020 +0000
Commit:     Joonas Niilola <juippis <AT> gentoo <DOT> org>
CommitDate: Thu Jun 25 11:18:23 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e218181a

net-misc/dahdi: fix install issue w.r.t. depmod.

If the kernel sources are not yet compiled, then there is no System.map,
and as a result the kernel build system won't run depmod, resulting in
the modules.* files normally generated by this to not exist.  This
causes the rm in the ebuild to fail.  Substitute with a find mechanism
that only deletes if it exists.

At the same time clean up some empty files on the image that carries
firmware version information which we don't care about.

Closes:  https://bugs.gentoo.org/725022
Package-Manager: Portage-2.3.99, Repoman-2.3.22
Signed-off-by: Jaco Kroon <jaco <AT> uls.co.za>
Closes: https://github.com/gentoo/gentoo/pull/16196
Signed-off-by: Joonas Niilola <juippis <AT> gentoo.org>

 net-misc/dahdi/dahdi-3.1.0-r1.ebuild | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/net-misc/dahdi/dahdi-3.1.0-r1.ebuild b/net-misc/dahdi/dahdi-3.1.0-r1.ebuild
index bd1d6c11293..f69efcbe418 100644
--- a/net-misc/dahdi/dahdi-3.1.0-r1.ebuild
+++ b/net-misc/dahdi/dahdi-3.1.0-r1.ebuild
@@ -97,5 +97,11 @@ src_install() {
 		DAHDI_MODULES_EXTRA="${JNET_DRIVERS// /.o }.o$(usex oslec " dahdi_echocan_oslec.o" "")" \
 		LDFLAGS="$(raw-ldflags)" install
 
-	rm -r "${ED}"/lib/modules/*/modules.* || die "Error removing bogus modules"
+	# Remove the blank "version" files (these files are all empty, and root owned).
+	find "${ED}/lib/firmware" -name ".*" -delete || die "Error removing empty firmware version files"
+
+	# If the kernel sources have a System.map, and there a suitable depmod
+	# available (seemingly when we're not cross-compiling), then the kernel
+	# sources depmod kicks in.  Remove the files caused by that.
+	find "${ED}/lib/modules" -name "modules.*" -delete || die "Error deleting bogus modules.* files"
 }


             reply	other threads:[~2020-06-25 11:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 11:18 Joonas Niilola [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-12  3:53 [gentoo-commits] repo/gentoo:master commit in: net-misc/dahdi/ Sam James
2022-06-30 21:47 Sam James
2022-06-30 21:47 Sam James
2021-03-26  7:50 Agostino Sarubbo
2021-03-12 18:35 Sam James
2021-01-22  6:35 Joonas Niilola
2020-08-08 12:18 Mikle Kolyada
2020-07-20 12:24 Sam James
2020-07-16 17:45 Sam James
2020-07-15 17:42 Sam James
2020-04-16  8:11 Joonas Niilola
2020-04-13 14:53 Agostino Sarubbo
2020-04-13 10:14 Agostino Sarubbo
2020-04-09 12:38 Joonas Niilola
2020-03-15 17:52 Joonas Niilola
2020-01-10  5:43 Joonas Niilola
2020-01-10  5:43 Joonas Niilola
2018-06-08 12:36 Tony Vroon
2017-02-22 22:05 Michael Weber
2017-02-22 22:03 Michael Weber
2017-02-22 21:02 Michael Weber
2016-03-31 10:54 Tony Vroon
2015-11-01 13:47 Mikle Kolyada
2015-10-27 12:18 Agostino Sarubbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593083903.e218181a346d02f68e92267d94f299319104d3b6.juippis@gentoo \
    --to=juippis@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox