From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DA908138350 for ; Sun, 19 Jan 2020 19:09:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0CBEDE0978; Sun, 19 Jan 2020 19:09:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E5CC5E0978 for ; Sun, 19 Jan 2020 19:09:17 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id F31F234E232 for ; Sun, 19 Jan 2020 19:09:15 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id E0DD7F0 for ; Sun, 19 Jan 2020 19:09:12 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579460032.4398c48f77ef4d1c3034549ebf5150f1173341f8.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qpkg.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 4398c48f77ef4d1c3034549ebf5150f1173341f8 X-VCS-Branch: master Date: Sun, 19 Jan 2020 19:09:12 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c3fc6f3f-68ba-4dff-87f1-be9b4e043616 X-Archives-Hash: 83c5b628a85c4665c0a47b7f7c71a66f commit: 4398c48f77ef4d1c3034549ebf5150f1173341f8 Author: Fabian Groffen gentoo org> AuthorDate: Sun Jan 19 18:53:52 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Sun Jan 19 18:53:52 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=4398c48f qpkg: fix Coverity 206544 Dereference null return value Signed-off-by: Fabian Groffen gentoo.org> qpkg.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qpkg.c b/qpkg.c index 562f9af..1eee7b1 100644 --- a/qpkg.c +++ b/qpkg.c @@ -262,7 +262,12 @@ qpkg_make(depend_atom *atom) xpaksize = st.st_size - xpaksize; /* save tbz2 tail: OOOOSTOP */ - fp = fopen(tbz2, "a"); + if ((fp = fopen(tbz2, "a")) == NULL) { + warnp("could not open '%s': %s", tbz2, strerror(errno)); + free(buf); + return 1; + } + WRITE_BE_INT32(buf, xpaksize); fwrite(buf, 1, 4, fp); fwrite("STOP", 1, 4, fp);