From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id CCD62138350 for ; Sun, 19 Jan 2020 19:09:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5F925E08BB; Sun, 19 Jan 2020 19:09:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 43A7CE0929 for ; Sun, 19 Jan 2020 19:09:15 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3EE8034E23A for ; Sun, 19 Jan 2020 19:09:14 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 303FD7E for ; Sun, 19 Jan 2020 19:09:12 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579456601.85355e52d5adaf79c8c69ae5dc46ebc62a2c8cde.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qlist.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 85355e52d5adaf79c8c69ae5dc46ebc62a2c8cde X-VCS-Branch: master Date: Sun, 19 Jan 2020 19:09:12 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c5343e52-3238-4d2a-8875-e6e3991a5029 X-Archives-Hash: 23224c9a350cce7e70d990e19f7e4092 commit: 85355e52d5adaf79c8c69ae5dc46ebc62a2c8cde Author: Fabian Groffen gentoo org> AuthorDate: Sun Jan 19 17:56:41 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Sun Jan 19 17:56:41 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=85355e52 qlist: fix Coverity 206555 Out-of-bounds read Signed-off-by: Fabian Groffen gentoo.org> qlist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qlist.c b/qlist.c index 506e3e5..cd60083 100644 --- a/qlist.c +++ b/qlist.c @@ -277,9 +277,9 @@ qlist_match( /* let's try exact matching w/out the PV */ i = snprintf(buf, sizeof(buf), "%s/%s", atom->CATEGORY, atom->PN); - if (uslot[0] != '\0' && i <= (int)sizeof(buf)) + if (uslot[0] != '\0' && i < (int)sizeof(buf)) i += snprintf(buf + i, sizeof(buf) - i, ":%s", atom->SLOT); - if (urepo && i <= (int)sizeof(buf)) + if (urepo && i < (int)sizeof(buf)) i += snprintf(buf + i, sizeof(buf) - i, "::%s", atom->REPO); /* exact match: CAT/PN[:SLOT][::REPO] */