From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8A0E9138334 for ; Mon, 15 Jul 2019 22:39:39 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B9A1BE083B; Mon, 15 Jul 2019 22:39:37 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9EF77E083B for ; Mon, 15 Jul 2019 22:39:37 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3972E347C54 for ; Mon, 15 Jul 2019 22:39:36 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id CAA4470D for ; Mon, 15 Jul 2019 22:39:32 +0000 (UTC) From: "Thomas Deutschmann" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Thomas Deutschmann" Message-ID: <1563229827.a280829317f5e6f22e3e8486a5f62bb2b979656f.whissi@gentoo> Subject: [gentoo-commits] proj/genkernel:master commit in: defaults/ X-VCS-Repository: proj/genkernel X-VCS-Files: defaults/initrd.scripts X-VCS-Directories: defaults/ X-VCS-Committer: whissi X-VCS-Committer-Name: Thomas Deutschmann X-VCS-Revision: a280829317f5e6f22e3e8486a5f62bb2b979656f X-VCS-Branch: master Date: Mon, 15 Jul 2019 22:39:32 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c5bb264f-972b-47d1-99b8-13333aeeeedc X-Archives-Hash: bec37d82e5e7c080bea10495831f82e0 commit: a280829317f5e6f22e3e8486a5f62bb2b979656f Author: Thomas Deutschmann gentoo org> AuthorDate: Mon Jul 15 22:30:27 2019 +0000 Commit: Thomas Deutschmann gentoo org> CommitDate: Mon Jul 15 22:30:27 2019 +0000 URL: https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=a2808293 initrd.script: prompt_user(): Remove read timeout It really makes no sense to timeout while reading user input: We only prompt when we are unable to continue. It's very unlikely that we are able to continue after some time without any changes. Instead, given that it can take some time to enter requested information, a timeout will likely result in bad user experience when user run into timeout while typing an UUID for example. Signed-off-by: Thomas Deutschmann gentoo.org> defaults/initrd.scripts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/defaults/initrd.scripts b/defaults/initrd.scripts index a47b1ed..4701857 100644 --- a/defaults/initrd.scripts +++ b/defaults/initrd.scripts @@ -944,12 +944,12 @@ prompt_user() { bad_msg '- type "shell" for a shell' bad_msg '- type "q" to skip ...' printf "%s" "${2}(${oldvalue}) :: " - read -t 10 ${1} - if [ $? -gt 0 ] - then - # prompt timed out - printf "\n" - fi + read ${1} + #if [ $? -gt 0 ] + #then + # # prompt timed out + # printf "\n" + #fi case $(eval echo '$'${1}) in 'q')