From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1BC33138334 for ; Thu, 27 Jun 2019 21:41:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2B03EE0872; Thu, 27 Jun 2019 21:41:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0B650E0872 for ; Thu, 27 Jun 2019 21:41:39 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 9BCE8346B2B for ; Thu, 27 Jun 2019 21:41:37 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 82AF9606 for ; Thu, 27 Jun 2019 21:41:35 +0000 (UTC) From: "Sergei Trofimovich" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sergei Trofimovich" Message-ID: <1561626596.604927f331829f971d3a32c2e67e0ad5ce3d8ee4.slyfox@gentoo> Subject: [gentoo-commits] proj/sandbox:master commit in: tests/ X-VCS-Repository: proj/sandbox X-VCS-Files: tests/atlocal.in tests/utimensat-3.sh X-VCS-Directories: tests/ X-VCS-Committer: slyfox X-VCS-Committer-Name: Sergei Trofimovich X-VCS-Revision: 604927f331829f971d3a32c2e67e0ad5ce3d8ee4 X-VCS-Branch: master Date: Thu, 27 Jun 2019 21:41:35 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 0697ddd8-de78-4455-8849-512ec55a11e4 X-Archives-Hash: 18d495fe729c580b96589550b281f32a commit: 604927f331829f971d3a32c2e67e0ad5ce3d8ee4 Author: Sergei Trofimovich gentoo org> AuthorDate: Thu Jun 27 09:09:56 2019 +0000 Commit: Sergei Trofimovich gentoo org> CommitDate: Thu Jun 27 09:09:56 2019 +0000 URL: https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=604927f3 tests: disable utimensat-3 on *-linux-musl x86_64-gentoo-linux-musl fails a single test: 83: utimensat/3 FAILED (utimensat.at:3) The test checks if sandbox does not crash when utimensat(, NULL, NULL, 0) is called. The behaviour is not specified by POSIX but glibc returns EINVAL for such a case. Thus the test behaves differently on varius libs. https://www.openwall.com/lists/musl/2019/06/25/1 has a conversation with musl upstream. The change restricts test down to glibc targets. Bug: https://bugs.gentoo.org/549108 Signed-off-by: Sergei Trofimovich gentoo.org> tests/atlocal.in | 1 + tests/utimensat-3.sh | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/tests/atlocal.in b/tests/atlocal.in index b9a631b..91b41b2 100644 --- a/tests/atlocal.in +++ b/tests/atlocal.in @@ -2,6 +2,7 @@ export abs_top_srcdir abs_top_builddir abs_srcdir abs_builddir export AWK="@AWK@" +export HOST="@host@" if ! ${at_clean} ; then export SB_UID=$(./get-user) diff --git a/tests/utimensat-3.sh b/tests/utimensat-3.sh index 4ecd4b3..a7b9843 100755 --- a/tests/utimensat-3.sh +++ b/tests/utimensat-3.sh @@ -1,6 +1,17 @@ #!/bin/sh # make sure NULL filename is handled correctly +# Note: this test is dependent on glibc internals +# other libcs chose not to validate invalid parameters: +# https://bugs.gentoo.org/549108#c28 +# https://www.openwall.com/lists/musl/2019/06/25/1 +# Run this test only on glibc systems. + +case $HOST in + *-linux-gnu);; + *) exit 77;; +esac + addwrite $PWD exec utimensat-0 -1:22 'f:O_WRONLY|O_CREAT:0666' NULL NULL 0