From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 81466138334 for ; Mon, 13 May 2019 18:52:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 996D4E08A4; Mon, 13 May 2019 18:52:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2343BE08A4 for ; Mon, 13 May 2019 18:52:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 94AF7344257 for ; Mon, 13 May 2019 18:52:12 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 1194B5E7 for ; Mon, 13 May 2019 18:52:11 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1557773422.858a4bf9eb22523b936651861d74780843d68f19.ulm@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: quickstart/ X-VCS-Repository: proj/devmanual X-VCS-Files: quickstart/text.xml X-VCS-Directories: quickstart/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: 858a4bf9eb22523b936651861d74780843d68f19 X-VCS-Branch: master Date: Mon, 13 May 2019 18:52:11 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: a0cbf2ce-799e-487b-9ef1-c13748488b9d X-Archives-Hash: 91725dfd97b15c4ade6ee5e9ee4970f4 commit: 858a4bf9eb22523b936651861d74780843d68f19 Author: Michał Górny gentoo org> AuthorDate: Mon Apr 22 07:22:44 2019 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Mon May 13 18:50:22 2019 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=858a4bf9 quickstart: Remove unnecessary src_install() from most examples Remove most of src_install() redefinitions since they completely match the default. Leave the initial one for demonstration purposes, and the last one since it is more complex. Signed-off-by: Michał Górny gentoo.org> Signed-off-by: Ulrich Müller gentoo.org> quickstart/text.xml | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/quickstart/text.xml b/quickstart/text.xml index 51f9962..d913374 100644 --- a/quickstart/text.xml +++ b/quickstart/text.xml @@ -225,11 +225,6 @@ DEPEND="${RDEPEND} src_configure() { econf --with-popt } - -src_install() { - emake DESTDIR="${D}" install - dodoc README CHANGES -}

@@ -241,7 +236,9 @@ variables see

-Again, we define src_configure and src_install functions. +We define src_configure only. src_install does not need to +be defined since the default implementation calling emake install +and installing common documentation files works correctly for the package.

@@ -291,11 +288,6 @@ src_prepare() { src_configure() { econf --with-popt } - -src_install() { - emake DESTDIR="${D}" install - dodoc README CHANGES -}

@@ -339,10 +331,6 @@ DEPEND="!sys-libs/glibc" src_configure() { econf $(use_enable nls) } - -src_install() { - emake DESTDIR="${D}" install -}