From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 294A1138334 for ; Tue, 8 Jan 2019 23:08:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DA534E0A52; Tue, 8 Jan 2019 23:08:24 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AC801E0A52 for ; Tue, 8 Jan 2019 23:08:24 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A53CB335D07 for ; Tue, 8 Jan 2019 23:08:22 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 629742A7 for ; Tue, 8 Jan 2019 23:08:20 +0000 (UTC) From: "Andreas Sturmlechner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" Message-ID: <1546988654.9b5037ebc0bb0ca8684ecd637b0bb819cdfab884.asturm@gentoo> Subject: [gentoo-commits] proj/kde:master commit in: eclass/ X-VCS-Repository: proj/kde X-VCS-Files: eclass/kde5.eclass X-VCS-Directories: eclass/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: 9b5037ebc0bb0ca8684ecd637b0bb819cdfab884 X-VCS-Branch: master Date: Tue, 8 Jan 2019 23:08:20 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 9ac396d7-f285-4ec1-acd8-a80211cf5307 X-Archives-Hash: 7361b47d30045fd66a45b613c7f6ef18 commit: 9b5037ebc0bb0ca8684ecd637b0bb819cdfab884 Author: Andreas Sturmlechner gentoo org> AuthorDate: Tue Jan 8 23:04:14 2019 +0000 Commit: Andreas Sturmlechner gentoo org> CommitDate: Tue Jan 8 23:04:14 2019 +0000 URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=9b5037eb kde5.eclass: Drop KDE_TESTPATTERN Never used by many ebuilds, completely unused right now. Bug: https://bugs.gentoo.org/674922 Signed-off-by: Andreas Sturmlechner gentoo.org> eclass/kde5.eclass | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/eclass/kde5.eclass b/eclass/kde5.eclass index fdabf26e85..d2f8515782 100644 --- a/eclass/kde5.eclass +++ b/eclass/kde5.eclass @@ -120,13 +120,6 @@ if [[ ${CATEGORY} = kde-frameworks ]]; then fi : ${KDE_QTHELP:=false} -# @ECLASS-VARIABLE: KDE_TESTPATTERN -# @DESCRIPTION: -# DANGER: Only touch it if you know what you are doing. -# By default, matches autotest(s), unittest(s) and test(s) pattern inside -# cmake add_subdirectory calls. -: ${KDE_TESTPATTERN:="\(auto|unit\)\?tests\?"} - # @ECLASS-VARIABLE: KDE_TEST # @DESCRIPTION: # If set to "false", do nothing. @@ -136,7 +129,7 @@ fi # If set to "forceoptional", remove a Qt5Test dependency and comment test # subdirs from the root CMakeLists.txt in addition to the above. # If set to "forceoptional-recursive", remove Qt5Test dependencies and make -# test subdirs according to KDE_TESTPATTERN from *any* CMakeLists.txt in ${S} +# autotest(s), unittest(s) and test(s) subdirs from *any* CMakeLists.txt in ${S} # and below conditional on BUILD_TESTING. This is always meant as a short-term # fix and creates ${T}/${P}-tests-optional.patch to refine and submit upstream. if [[ ${CATEGORY} = kde-frameworks ]]; then @@ -579,12 +572,12 @@ kde5_src_prepare() { local f pf="${T}/${P}"-tests-optional.patch touch ${pf} || die "Failed to touch patch file" for f in $(find . -type f -name "CMakeLists.txt" -exec \ - grep -l "^\s*add_subdirectory\s*\(\s*.*${KDE_TESTPATTERN}\s*)\s*\)" {} \;); do + grep -l "^\s*add_subdirectory\s*\(\s*.*\(auto|unit\)\?tests\?\s*)\s*\)" {} \;); do cp ${f} ${f}.old || die "Failed to prepare patch origfile" pushd ${f%/*} > /dev/null || die punt_bogus_dep Qt5 Test sed -i CMakeLists.txt -e \ - "/^#/! s/add_subdirectory\s*\(\s*.*${KDE_TESTPATTERN}\s*)\s*\)/if(BUILD_TESTING)\n&\nendif()/" \ + "/^#/! s/add_subdirectory\s*\(\s*.*\(auto|unit\)\?tests\?\s*)\s*\)/if(BUILD_TESTING)\n&\nendif()/" \ || die popd > /dev/null || die diff -Naur ${f}.old ${f} 1>>${pf}