From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5C34A138334 for ; Fri, 14 Sep 2018 05:40:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 31A72E0DCE; Fri, 14 Sep 2018 05:40:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 02991E0DCE for ; Fri, 14 Sep 2018 05:40:52 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id AFC04335D0C for ; Fri, 14 Sep 2018 05:40:48 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 8C0C43D2 for ; Fri, 14 Sep 2018 05:40:46 +0000 (UTC) From: "Matt Turner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Matt Turner" Message-ID: <1536903263.35a3cfc97b35b5a4005f8f6a835e323321d06734.mattst88@gentoo> Subject: [gentoo-commits] proj/catalyst:master commit in: targets/support/ X-VCS-Repository: proj/catalyst X-VCS-Files: targets/support/kmerge.sh X-VCS-Directories: targets/support/ X-VCS-Committer: mattst88 X-VCS-Committer-Name: Matt Turner X-VCS-Revision: 35a3cfc97b35b5a4005f8f6a835e323321d06734 X-VCS-Branch: master Date: Fri, 14 Sep 2018 05:40:46 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 833e7892-b893-41ff-a5e9-c620197297f7 X-Archives-Hash: 00405b4834ce6b49508b892b391cc755 commit: 35a3cfc97b35b5a4005f8f6a835e323321d06734 Author: Matt Turner gentoo org> AuthorDate: Fri Sep 14 05:34:23 2018 +0000 Commit: Matt Turner gentoo org> CommitDate: Fri Sep 14 05:34:23 2018 +0000 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=35a3cfc9 kmerge.sh: Handle gk_kernargs with spaces The ppc livecd specs contain boot/kernel/G5/gk_kernargs: --kernel-cc='gcc -m64' --kernel-ld='ld -m elf64ppc' --kernel-as='as -a64' And the eval converted that into a sequence of arguments separated by spaces, ultimately resulting in '--kernel-cc=gcc' '-m64' being passed to genkernel, breaking the build. Thanks a ton to James Le Cuirot gentoo.org> and Doug Freed mtu.edu> for their help in debugging this. The credit goes to James for coming up with this fix. targets/support/kmerge.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/targets/support/kmerge.sh b/targets/support/kmerge.sh index 029b2a33..429e6a98 100755 --- a/targets/support/kmerge.sh +++ b/targets/support/kmerge.sh @@ -144,7 +144,7 @@ filtered_kname=${clst_kname/\//_} filtered_kname=${filtered_kname/\./_} eval "clst_kernel_use=\$clst_boot_kernel_${filtered_kname}_use" -eval "clst_kernel_gk_kernargs=\$clst_boot_kernel_${filtered_kname}_gk_kernargs" +eval eval clst_kernel_gk_kernargs=( \$clst_boot_kernel_${filtered_kname}_gk_kernargs ) eval "clst_ksource=\$clst_boot_kernel_${filtered_kname}_sources" if [ -z "${clst_ksource}" ]