From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1045443-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C5C64138334 for <garchives@archives.gentoo.org>; Wed, 5 Sep 2018 21:08:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 75E08E07D1; Wed, 5 Sep 2018 21:08:08 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3A9AAE07D1 for <gentoo-commits@lists.gentoo.org>; Wed, 5 Sep 2018 21:08:08 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 29DD4335CCA for <gentoo-commits@lists.gentoo.org>; Wed, 5 Sep 2018 21:08:06 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C1C053BF for <gentoo-commits@lists.gentoo.org>; Wed, 5 Sep 2018 21:08:03 +0000 (UTC) From: "Andreas Sturmlechner" <asturm@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" <asturm@gentoo.org> Message-ID: <1536181601.4a879481536068780fda845e214f5f6f28128860.asturm@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/beets/ X-VCS-Repository: repo/gentoo X-VCS-Files: media-sound/beets/beets-1.4.7.ebuild X-VCS-Directories: media-sound/beets/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: 4a879481536068780fda845e214f5f6f28128860 X-VCS-Branch: master Date: Wed, 5 Sep 2018 21:08:03 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 63e3c969-e6a0-45b6-8aa2-62a41075a36f X-Archives-Hash: 2583c4fb27ced9197c6d162b9ea2a54d commit: 4a879481536068780fda845e214f5f6f28128860 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> AuthorDate: Wed Sep 5 20:43:42 2018 +0000 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> CommitDate: Wed Sep 5 21:06:41 2018 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a879481 media-sound/beets: Remove USE flac,ogg,opus; fix USE gstreamer They were effectively only used if USE +replaygain +gstreamer were enabled, not ticking any build switches but purely forwarding USE dependencies. Depend on media-plugins/gst-plugins-meta instead. gstreamer is also being used if USE +mpd. Reviewed-by: Mart Raudsepp <leio <AT> gentoo.org> Quote: replaygain uses decodebin, thus should depend on media-plugins/gst-plugins-meta:1.0 to pull in any decided by user decoders. It uses rganalysis explicitly, for which it needs to depend on media-libs/gst-plugins-good:1.0. Other explicitly used elements are all from core or base, thus the gst-plugins-meta dep will cover it, or you can be explicit (core = media-libs/gstreamer). Additionally there is beetsplug/bpd/gstplayer.py that uses playbin. I don't know what that thing is about, but it seems irrelevant to replaygain, so might want a gstreamer? ( media-plugins/gst-plugins-meta:1.0 ) independent of USE=replaygain, if it's optional enough to work fine without it installed without losing anything important. Package-Manager: Portage-2.3.49, Repoman-2.3.10 media-sound/beets/beets-1.4.7.ebuild | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/media-sound/beets/beets-1.4.7.ebuild b/media-sound/beets/beets-1.4.7.ebuild index 7a21e504abd..b0ea1935a00 100644 --- a/media-sound/beets/beets-1.4.7.ebuild +++ b/media-sound/beets/beets-1.4.7.ebuild @@ -17,7 +17,7 @@ HOMEPAGE="http://beets.io/ https://pypi.org/project/beets/" KEYWORDS="~amd64 ~x86" SLOT="0" LICENSE="MIT" -IUSE="badfiles chromaprint doc discogs ffmpeg flac gstreamer lastfm mpd ogg opus replaygain test thumbnail webserver" +IUSE="badfiles chromaprint doc discogs ffmpeg gstreamer lastfm mpd replaygain test thumbnail webserver" RDEPEND=" dev-python/jellyfish[${PYTHON_USEDEP}] @@ -45,15 +45,13 @@ RDEPEND=" mpd? ( dev-python/bluelet[${PYTHON_USEDEP}] dev-python/python-mpd[${PYTHON_USEDEP}] + gstreamer? ( media-plugins/gst-plugins-meta:1.0 ) ) replaygain? ( gstreamer? ( dev-python/pygobject:3[${PYTHON_USEDEP}] - media-libs/gstreamer:1.0[introspection] - media-libs/gst-plugins-base:1.0[ogg?] media-libs/gst-plugins-good:1.0 - flac? ( media-plugins/gst-plugins-flac:1.0 ) - opus? ( media-plugins/gst-plugins-opus:1.0 ) + media-plugins/gst-plugins-meta:1.0 ) !gstreamer? ( media-sound/mp3gain ) )