From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8E6A41382C5 for ; Wed, 7 Feb 2018 15:00:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CC40AE0AAB; Wed, 7 Feb 2018 15:00:58 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AE660E0AAB for ; Wed, 7 Feb 2018 15:00:58 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id AACBA335C48 for ; Wed, 7 Feb 2018 15:00:57 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 0D9911DE for ; Wed, 7 Feb 2018 15:00:56 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1518009727.a9971615ef69dbb26f04af2c9fd1cddd1ec6d626.ulm@gentoo> Subject: [gentoo-commits] data/glep:master commit in: / X-VCS-Repository: data/glep X-VCS-Files: glep-0075.rst X-VCS-Directories: / X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: a9971615ef69dbb26f04af2c9fd1cddd1ec6d626 X-VCS-Branch: master Date: Wed, 7 Feb 2018 15:00:56 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 31e8ca08-ee25-4b37-99c0-cf355f1e3f3c X-Archives-Hash: d95b74b8dc1b01c8918251ae20a889f4 commit: a9971615ef69dbb26f04af2c9fd1cddd1ec6d626 Author: Michał Górny gentoo org> AuthorDate: Sun Jan 28 08:55:35 2018 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Wed Feb 7 13:22:07 2018 +0000 URL: https://gitweb.gentoo.org/data/glep.git/commit/?id=a9971615 glep-0075: Include argument on injected distfiles Include the argument that we have injected distfiles as noted on the bug by Robin. Inclusion suggested by Michael Orlitzky. glep-0075.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/glep-0075.rst b/glep-0075.rst index c0a1d5c..ced1231 100644 --- a/glep-0075.rst +++ b/glep-0075.rst @@ -205,7 +205,7 @@ to split them further. The alternate option of using file hash has the advantage of having a more balanced split. Furthermore, since hashes are stored -in Manifests using them is zero-cost. However, this solution has two +in Manifests using them is zero-cost. However, this solution has three significant disadvantages: 1. The hash values are unknown for newly-downloaded distfiles, so @@ -216,6 +216,9 @@ significant disadvantages: hash mismatches would be placed in the wrong subdirectory, potentially causing confusing errors. +3. Not all files in the distfiles tree are covered by package Manifests + --- there are additional files that are injected into distfiles. + Using filename hashes has proven to provide a similar balance to using file hashes. Furthermore, since filenames are known up front this solution does not suffer from the both listed problems. While