From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-982251-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id 32DD71396D9
for <garchives@archives.gentoo.org>; Sat, 4 Nov 2017 23:40:26 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 963D7E0EB7;
Sat, 4 Nov 2017 23:40:24 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 742E6E0EB7
for <gentoo-commits@lists.gentoo.org>; Sat, 4 Nov 2017 23:40:23 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.gentoo.org (Postfix) with ESMTPS id 0AB38341772
for <gentoo-commits@lists.gentoo.org>; Sat, 4 Nov 2017 23:40:22 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
by oystercatcher.gentoo.org (Postfix) with ESMTP id 5E726952A
for <gentoo-commits@lists.gentoo.org>; Sat, 4 Nov 2017 23:40:20 +0000 (UTC)
From: "Michael Orlitzky" <mjo@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Michael Orlitzky" <mjo@gentoo.org>
Message-ID: <1509838641.6a5bac28672abbc54f164d853d929a3e4d8b654d.mjo@gentoo>
Subject: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/pnp4nagios/
X-VCS-Repository: repo/gentoo
X-VCS-Files: net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r2.ebuild net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r3.ebuild
X-VCS-Directories: net-analyzer/pnp4nagios/
X-VCS-Committer: mjo
X-VCS-Committer-Name: Michael Orlitzky
X-VCS-Revision: 6a5bac28672abbc54f164d853d929a3e4d8b654d
X-VCS-Branch: master
Date: Sat, 4 Nov 2017 23:40:20 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Archives-Salt: 937a5250-0471-4e3f-9f21-2d880d8df796
X-Archives-Hash: 83d8fbed8860a312d3b35d8cc9832725
commit: 6a5bac28672abbc54f164d853d929a3e4d8b654d
Author: Michael Orlitzky <mjo <AT> gentoo <DOT> org>
AuthorDate: Thu Nov 2 17:27:17 2017 +0000
Commit: Michael Orlitzky <mjo <AT> gentoo <DOT> org>
CommitDate: Sat Nov 4 23:37:21 2017 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a5bac28
net-analyzer/pnp4nagios: new revision to fix insecure config permissions.
Previous revisions of pnp4nagios install /etc/pnp owned by the "nagios
user," and the npcd daemon also runs as that user. That configuration
is insecure: the unprivileged user can edit /etc/pnp/npcd.cfg, and
escalate his own privileges by setting "user = root". To avoid the
problem, we set INSTALL_OPTS="" while running "emake install". That
leaves all of /etc/pnp with the default (root:root) ownership.
Bug: https://github.com/lingej/pnp4nagios/issues/140
Package-Manager: Portage-2.3.8, Repoman-2.3.3
.../{pnp4nagios-0.6.26-r2.ebuild => pnp4nagios-0.6.26-r3.ebuild} | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r2.ebuild b/net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r3.ebuild
similarity index 93%
rename from net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r2.ebuild
rename to net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r3.ebuild
index 818bc3104ff..ce886f53738 100644
--- a/net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r2.ebuild
+++ b/net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r3.ebuild
@@ -68,7 +68,9 @@ src_compile() {
}
src_install() {
- emake DESTDIR="${D}" install install-config
+ # Don't use INSTALL_OPTS because they set insecure permissions on
+ # all of /etc/pnp (https://github.com/lingej/pnp4nagios/issues/140).
+ emake INSTALL_OPTS="" DESTDIR="${D}" install install-config
einstalldocs
newinitd "${FILESDIR}"/npcd.initd npcd
rm "${ED%/}/usr/share/pnp/install.php" || \