[gentoo-commits] proj/perl-overlay:master commit in: eclass/

["Kent Fredric" <kentnl@gentoo.org>]

commit:     11e52068ff5158fdf6aaae7482441b306748ef45
Author:     Kent Fredric <kentnl <AT> gentoo <DOT> org>
AuthorDate: Fri Sep 15 20:54:10 2017 +0000
Commit:     Kent Fredric <kentnl <AT> gentoo <DOT> org>
CommitDate: Sun Sep 17 00:39:37 2017 +0000
URL:        https://gitweb.gentoo.org/proj/perl-overlay.git/commit/?id=11e52068

perl-module.eclass: run perl_check_eapi in src_configure

I had to think long and hard about where to put this :/

Putting it where it should be logically:

* pkg_setup:
    Downsides: new phase function people won't expect to be there
    Downsides: makes extra work for the common definition of pkg_setup

* src_unpack:
    Downsides: Same as pkg_setup

* src_pretend:
    Downsides: Too early
    Downsides: makes all perl modules slow to install

* global
    Downsides: makes metadata collection very slow
    Downsides: risks running too much code in global scope

* src_configre:
    Downsides: risks only discovering the bug after shipping

However, the case of the last one dictates that the maintainer did
significant changes, and then never even compile tested it.

Maintainer rightly gets a rap over the knuckles and such things should
never be stable

 eclass/perl-module.eclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
index 3b4971389..5789d96bf 100644
--- a/eclass/perl-module.eclass
+++ b/eclass/perl-module.eclass
@@ -228,6 +228,7 @@ perl-module_src_configure() {
 	fi
 	SRC_PREP="yes"
 
+	perl_check_eapi
 	perl_check_env
 
 	perl_set_version