From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C61EC1396D0 for ; Thu, 31 Aug 2017 14:07:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F2FE81FC041; Thu, 31 Aug 2017 14:07:16 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CE9F11FC041 for ; Thu, 31 Aug 2017 14:07:16 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B772033BE2E for ; Thu, 31 Aug 2017 14:07:15 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 5DE3D8914 for ; Thu, 31 Aug 2017 14:07:14 +0000 (UTC) From: "Michał Górny" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michał Górny" Message-ID: <1504188374.249ecdadd63b2b743d670f2776fe976d22e8808c.mgorny@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/ebuild.sh X-VCS-Directories: bin/ X-VCS-Committer: mgorny X-VCS-Committer-Name: Michał Górny X-VCS-Revision: 249ecdadd63b2b743d670f2776fe976d22e8808c X-VCS-Branch: master Date: Thu, 31 Aug 2017 14:07:14 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 0012d63e-36b2-458e-b881-98e617452810 X-Archives-Hash: 3b3d838e17d6796c9d6abe50a6c134c7 commit: 249ecdadd63b2b743d670f2776fe976d22e8808c Author: Michał Górny gentoo org> AuthorDate: Wed Aug 30 08:58:36 2017 +0000 Commit: Michał Górny gentoo org> CommitDate: Thu Aug 31 14:06:14 2017 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=249ecdad ebuild.sh: Explicitly ban get_libdir in global scope The value of get_libdir depends on the profile, and so it is not useful for dependency calculations. Furthermore, it seems that Portage does not handle defining it in global scope well due to EAPI checking magic. Ban it completely where it is defined as EAPI function to let developers catch their mistakes early rather than see them as 'command not found' errors during dependency calculation / cache updates. Bug: https://bugs.gentoo.org/629010 Closes: https://github.com/gentoo/portage/pull/197 Reviewed-by: Zac Medico gentoo.org> bin/ebuild.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/ebuild.sh b/bin/ebuild.sh index a400ef72e..f1ac3f278 100755 --- a/bin/ebuild.sh +++ b/bin/ebuild.sh @@ -66,6 +66,7 @@ else use useq usev use_with use_enable" ___eapi_has_usex && funcs+=" usex" ___eapi_has_in_iuse && funcs+=" in_iuse" + ___eapi_has_get_libdir && funcs+=" get_libdir" # These functions die because calls to them during the "depend" phase # are considered to be severe QA violations. funcs+=" best_version has_version portageq"