From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id EEBE91396D0 for ; Thu, 24 Aug 2017 19:02:07 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 404C8E0D2E; Thu, 24 Aug 2017 19:02:07 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 21945E0D20 for ; Thu, 24 Aug 2017 19:02:07 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 47C2634069A for ; Thu, 24 Aug 2017 19:02:06 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id A3CF6814A for ; Thu, 24 Aug 2017 19:02:04 +0000 (UTC) From: "Göktürk Yüksek" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Göktürk Yüksek" Message-ID: <1503601035.53b55350b50b480aae6f4e2ae9c93b023d8b02c1.gokturk@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/functions/src_test/ X-VCS-Repository: proj/devmanual X-VCS-Files: ebuild-writing/functions/src_test/text.xml X-VCS-Directories: ebuild-writing/functions/src_test/ X-VCS-Committer: gokturk X-VCS-Committer-Name: Göktürk Yüksek X-VCS-Revision: 53b55350b50b480aae6f4e2ae9c93b023d8b02c1 X-VCS-Branch: master Date: Thu, 24 Aug 2017 19:02:04 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: ec6f0a5c-c5aa-49b1-b59d-50d87ea4fd79 X-Archives-Hash: dac5705de1c273dae5af8ea9ea0f4341 commit: 53b55350b50b480aae6f4e2ae9c93b023d8b02c1 Author: Michał Górny gentoo org> AuthorDate: Sun May 7 18:51:48 2017 +0000 Commit: Göktürk Yüksek gentoo org> CommitDate: Thu Aug 24 18:57:15 2017 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=53b55350 ebuild-writing/.../src_test: Do not encourage make, use 'emake -j1' instead Replace the call to 'make' with 'emake -j1'. This was an old, bad recommendation. Furthermore, remove the whole paragraph suggesting not to use emake -- nowadays, most of the test suites work fine in parallel. ebuild-writing/functions/src_test/text.xml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/ebuild-writing/functions/src_test/text.xml b/ebuild-writing/functions/src_test/text.xml index 70b6212..ca13a07 100644 --- a/ebuild-writing/functions/src_test/text.xml +++ b/ebuild-writing/functions/src_test/text.xml @@ -65,8 +65,8 @@ src_test() { sed -i -e 's~test49.out~~g' Makefile || die # Try to run the non-gui tests only - make test-nongui \ - || die "At least one test failed" + # pass -j1 if tests do not support being run in parallel + emake -j1 test-nongui } @@ -96,12 +96,6 @@ using sed or skipping a particular make target is sufficient.

- -emake should not be used for src_test trying to -parallelise tests unless the Makefile was specifically designed -for this can cause all sorts of strange problems. - -

Try to ensure that tests work properly for your ebuild. A good test suite is extremely helpful for arch maintainers.