[gentoo-commits] proj/devmanual:master commit in: ebuild-writing/functions/src_test/

["Göktürk Yüksek" <gokturk@gentoo.org>]

commit:     53b55350b50b480aae6f4e2ae9c93b023d8b02c1
Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Sun May  7 18:51:48 2017 +0000
Commit:     Göktürk Yüksek <gokturk <AT> gentoo <DOT> org>
CommitDate: Thu Aug 24 18:57:15 2017 +0000
URL:        https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=53b55350

ebuild-writing/.../src_test: Do not encourage make, use 'emake -j1' instead

Replace the call to 'make' with 'emake -j1'. This was an old, bad
recommendation. Furthermore, remove the whole paragraph suggesting
not to use emake -- nowadays, most of the test suites work fine
in parallel.

 ebuild-writing/functions/src_test/text.xml | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/ebuild-writing/functions/src_test/text.xml b/ebuild-writing/functions/src_test/text.xml
index 70b6212..ca13a07 100644
--- a/ebuild-writing/functions/src_test/text.xml
+++ b/ebuild-writing/functions/src_test/text.xml
@@ -65,8 +65,8 @@ src_test() {
     sed -i -e 's~test49.out~~g' Makefile || die
 
     # Try to run the non-gui tests only
-    make test-nongui \
-            || die "At least one test failed"
+    # pass -j1 if tests do not support being run in parallel
+    emake -j1 test-nongui
 }
 </codesample>
 </body>
@@ -96,12 +96,6 @@ using <c>sed</c> or skipping a particular <c>make</c> target is
 sufficient.
 </p>
 
-<note>
-<c>emake</c> should not be used for <c>src_test</c> <d/> trying to
-parallelise tests unless the <c>Makefile</c> was specifically designed
-for this can cause all sorts of strange problems.
-</note>
-
 <p>
 Try to ensure that tests work properly for your ebuild. A good test
 suite is extremely helpful for arch maintainers.