From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9EC38139694 for ; Sat, 18 Mar 2017 16:58:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0BA5521C080; Sat, 18 Mar 2017 16:58:58 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DF0EE21C080 for ; Sat, 18 Mar 2017 16:58:57 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E4893341398 for ; Sat, 18 Mar 2017 16:58:56 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id AFA486CAB for ; Sat, 18 Mar 2017 16:58:55 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1489856300.fd5633bbea42e0a0dadd405960afc79460efbc07.ulm@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/functions/pkg_nofetch/ X-VCS-Repository: proj/devmanual X-VCS-Files: ebuild-writing/functions/pkg_nofetch/text.xml X-VCS-Directories: ebuild-writing/functions/pkg_nofetch/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: fd5633bbea42e0a0dadd405960afc79460efbc07 X-VCS-Branch: master Date: Sat, 18 Mar 2017 16:58:55 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 6df76cc1-ba43-4846-8e23-bc8796501f13 X-Archives-Hash: 77edfd0144ff8c7ad47a16a343ffccd4 commit: fd5633bbea42e0a0dadd405960afc79460efbc07 Author: Ulrich Müller kph uni-mainz de> AuthorDate: Fri Mar 17 09:41:55 2017 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Sat Mar 18 16:58:20 2017 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=fd5633bb ebuild-writing/functions/pkg_nofetch: Do not reference DISTDIR. According to PMS, the DISTDIR variable is not valid in pkg_* phases. In addition, it is not guaranteed to be consistent across the ebuild environment. So the package manager is allowed to (and Portage does) redefine it to point to a temporary "shadow" instead of the global distfiles directory. Bug: 612882 ebuild-writing/functions/pkg_nofetch/text.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ebuild-writing/functions/pkg_nofetch/text.xml b/ebuild-writing/functions/pkg_nofetch/text.xml index f360607..a03d552 100644 --- a/ebuild-writing/functions/pkg_nofetch/text.xml +++ b/ebuild-writing/functions/pkg_nofetch/text.xml @@ -54,9 +54,13 @@ pkg_nofetch() { einfo "Please download" einfo " - ${P}-main.tar.bz2" einfo " - ${P}-extras.tar.bz2" - einfo "from ${HOMEPAGE} and place them in ${DISTDIR}" + einfo "from ${HOMEPAGE} and place them in your DISTDIR directory." } + +The DISTDIR variable is not valid in pkg_* phases, so it must not +be referenced. +