[gentoo-commits] proj/devmanual:master commit in: ebuild-writing/functions/pkg_nofetch/

[gentoo-commits] proj/devmanual:master commit in: ebuild-writing/functions/pkg_nofetch/

[Ulrich Müller]

commit:     fd5633bbea42e0a0dadd405960afc79460efbc07
Author:     Ulrich Müller <ulm <AT> kph <DOT> uni-mainz <DOT> de>
AuthorDate: Fri Mar 17 09:41:55 2017 +0000
Commit:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Sat Mar 18 16:58:20 2017 +0000
URL:        https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=fd5633bb

ebuild-writing/functions/pkg_nofetch: Do not reference DISTDIR.

According to PMS, the DISTDIR variable is not valid in pkg_* phases.
In addition, it is not guaranteed to be consistent across the ebuild
environment. So the package manager is allowed to (and Portage does)
redefine it to point to a temporary "shadow" instead of the global
distfiles directory.

Bug: 612882

 ebuild-writing/functions/pkg_nofetch/text.xml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ebuild-writing/functions/pkg_nofetch/text.xml b/ebuild-writing/functions/pkg_nofetch/text.xml
index f360607..a03d552 100644
--- a/ebuild-writing/functions/pkg_nofetch/text.xml
+++ b/ebuild-writing/functions/pkg_nofetch/text.xml
@@ -54,9 +54,13 @@ pkg_nofetch() {
     einfo "Please download"
     einfo "  - ${P}-main.tar.bz2"
     einfo "  - ${P}-extras.tar.bz2"
-    einfo "from ${HOMEPAGE} and place them in ${DISTDIR}"
+    einfo "from ${HOMEPAGE} and place them in your DISTDIR directory."
 }
 </codesample>
+<note>
+The <c>DISTDIR</c> variable is not valid in <c>pkg_*</c> phases, so it must not
+be referenced.
+</note>
 </body>
 </section>