public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Aaron Swenson" <titanofold@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/postgresql/eselect:stateless commit in: /
Date: Mon,  6 Feb 2017 13:19:43 +0000 (UTC)	[thread overview]
Message-ID: <1486382029.4a6f0ad3208a0e27a24377c4a2aa3d3cb78517c4.titanofold@gentoo> (raw)

commit:     4a6f0ad3208a0e27a24377c4a2aa3d3cb78517c4
Author:     Aaron W. Swenson <titanofold <AT> gentoo <DOT> org>
AuthorDate: Mon Feb  6 11:53:49 2017 +0000
Commit:     Aaron Swenson <titanofold <AT> gentoo <DOT> org>
CommitDate: Mon Feb  6 11:53:49 2017 +0000
URL:        https://gitweb.gentoo.org/proj/postgresql/eselect.git/commit/?id=4a6f0ad3

Remove redundant do_unset() call

do_set() calls do_unset(). No need to call it before do_set().

 postgresql.eselect | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/postgresql.eselect b/postgresql.eselect
index 83db02f..d7229e5 100644
--- a/postgresql.eselect
+++ b/postgresql.eselect
@@ -382,11 +382,8 @@ do_update() {
 		# may have changed.
 		do_set ${active_slot}
 	elif [[ ${#slots[@]} -ne 0 ]] ; then
-		# If $slots is not empty but ${active_slot} is set, the active_slot
-		# must have been unmerged and its links need to be cleaned before...
-		[[ ${active_slot} != "(none)" ]] && do_unset ${active_slot}
-
-		# Setting the highest slot available.
+		# If $slots is not empty and active_slot is not in the list, set the
+		# highest slot available.
 		do_set ${slots[-1]}
 	elif [[ ${active_slot} != "(none)" ]] ; then
 		# If slots is empty, but active_slot still has a value, an unset must


WARNING: multiple messages have this Message-ID (diff)
From: "Aaron Swenson" <titanofold@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/postgresql/eselect:master commit in: /
Date: Tue, 18 Apr 2017 19:43:37 +0000 (UTC)	[thread overview]
Message-ID: <1486382029.4a6f0ad3208a0e27a24377c4a2aa3d3cb78517c4.titanofold@gentoo> (raw)
Message-ID: <20170418194337.k3Ltg8Q_HQqmOIGFQGtGeu8OYbKF7ecGpzq46diUGUM@z> (raw)

commit:     4a6f0ad3208a0e27a24377c4a2aa3d3cb78517c4
Author:     Aaron W. Swenson <titanofold <AT> gentoo <DOT> org>
AuthorDate: Mon Feb  6 11:53:49 2017 +0000
Commit:     Aaron Swenson <titanofold <AT> gentoo <DOT> org>
CommitDate: Mon Feb  6 11:53:49 2017 +0000
URL:        https://gitweb.gentoo.org/proj/postgresql/eselect.git/commit/?id=4a6f0ad3

Remove redundant do_unset() call

do_set() calls do_unset(). No need to call it before do_set().

 postgresql.eselect | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/postgresql.eselect b/postgresql.eselect
index 83db02f..d7229e5 100644
--- a/postgresql.eselect
+++ b/postgresql.eselect
@@ -382,11 +382,8 @@ do_update() {
 		# may have changed.
 		do_set ${active_slot}
 	elif [[ ${#slots[@]} -ne 0 ]] ; then
-		# If $slots is not empty but ${active_slot} is set, the active_slot
-		# must have been unmerged and its links need to be cleaned before...
-		[[ ${active_slot} != "(none)" ]] && do_unset ${active_slot}
-
-		# Setting the highest slot available.
+		# If $slots is not empty and active_slot is not in the list, set the
+		# highest slot available.
 		do_set ${slots[-1]}
 	elif [[ ${active_slot} != "(none)" ]] ; then
 		# If slots is empty, but active_slot still has a value, an unset must


             reply	other threads:[~2017-02-06 13:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 13:19 Aaron Swenson [this message]
2017-04-18 19:43 ` [gentoo-commits] proj/postgresql/eselect:master commit in: / Aaron Swenson
  -- strict thread matches above, loose matches on Subject: below --
2017-04-18 19:43 [gentoo-commits] proj/postgresql/eselect:stateless " Aaron Swenson
2017-04-18 19:43 [gentoo-commits] proj/postgresql/eselect:master " Aaron Swenson
2017-02-06 13:19 ` [gentoo-commits] proj/postgresql/eselect:stateless " Aaron Swenson
2017-04-18 19:43 [gentoo-commits] proj/postgresql/eselect:master " Aaron Swenson
2017-04-12 12:54 ` [gentoo-commits] proj/postgresql/eselect:stateless " Aaron Swenson
2017-04-18 19:43 [gentoo-commits] proj/postgresql/eselect:master " Aaron Swenson
2017-02-06 13:19 ` [gentoo-commits] proj/postgresql/eselect:stateless " Aaron Swenson
2017-04-18 19:43 [gentoo-commits] proj/postgresql/eselect:master " Aaron Swenson
2017-02-04 21:15 ` [gentoo-commits] proj/postgresql/eselect:stateless " Aaron Swenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486382029.4a6f0ad3208a0e27a24377c4a2aa3d3cb78517c4.titanofold@gentoo \
    --to=titanofold@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox