From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 08C7E139085 for ; Tue, 31 Jan 2017 03:28:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 11EB2E0BA8; Tue, 31 Jan 2017 03:28:25 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E4FA821C04E for ; Tue, 31 Jan 2017 03:28:24 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0F052341679 for ; Tue, 31 Jan 2017 03:28:24 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 799043BA2 for ; Tue, 31 Jan 2017 03:28:22 +0000 (UTC) From: "Michael Orlitzky" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michael Orlitzky" Message-ID: <1485833251.c0507ac8482881f315fc92b4b6f89fc58bd4b1f9.mjo@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: mail-filter/spamassassin/ X-VCS-Repository: repo/gentoo X-VCS-Files: mail-filter/spamassassin/spamassassin-3.4.1-r10.ebuild X-VCS-Directories: mail-filter/spamassassin/ X-VCS-Committer: mjo X-VCS-Committer-Name: Michael Orlitzky X-VCS-Revision: c0507ac8482881f315fc92b4b6f89fc58bd4b1f9 X-VCS-Branch: master Date: Tue, 31 Jan 2017 03:28:22 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: b0e8ea5b-b541-43ed-8b94-6ae84422408f X-Archives-Hash: 854fe7ac8c6955231e3e3cd065bd0d8d commit: c0507ac8482881f315fc92b4b6f89fc58bd4b1f9 Author: Michael Orlitzky gentoo org> AuthorDate: Tue Jan 31 03:02:27 2017 +0000 Commit: Michael Orlitzky gentoo org> CommitDate: Tue Jan 31 03:27:31 2017 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0507ac8 mail-filter/spamassassin: disable interactive prompts properly. The PERL_MM_USE_DEFAULT variable is used to disable the interactive prompts in SpamAssassin's build system. However, when I dropped the perl-module.eclass a while back, I only set the variable where it seemed to be necessary. Where it is necessary turns out to depend on the package manager, because different package managers may treat the controlling terminal and file descriptors differently, and that's how MakeMaker decides whether or not to prompt you. That problem manifests in Paludis, and is hopefully fixed by exporting PERL_MM_USE_DEFAULT=1 sooner, in src_configure(). This change should only affect the build, so it is made without a new revision. Gentoo-Bug: 604518 Package-Manager: portage-2.3.0 mail-filter/spamassassin/spamassassin-3.4.1-r10.ebuild | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/mail-filter/spamassassin/spamassassin-3.4.1-r10.ebuild b/mail-filter/spamassassin/spamassassin-3.4.1-r10.ebuild index 9ba34fc..c2776ef 100644 --- a/mail-filter/spamassassin/spamassassin-3.4.1-r10.ebuild +++ b/mail-filter/spamassassin/spamassassin-3.4.1-r10.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2016 Gentoo Foundation +# Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ @@ -104,6 +104,10 @@ src_prepare() { } src_configure() { + # This is how and where the perl-module eclass disables the + # MakeMaker interactive prompt. + export PERL_MM_USE_DEFAULT=1 + # Set SYSCONFDIR explicitly so we can't get bitten by bug 48205 again # (just to be sure, nobody knows how it could happen in the first place). # @@ -124,11 +128,8 @@ src_configure() { } src_compile() { - PERL_MM_USE_DEFAULT=1 emake - - if use qmail; then - emake spamc/qmail-spamc - fi + emake + use qmail && emake spamc/qmail-spamc } src_install () {