From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5EA6B139085 for ; Sun, 22 Jan 2017 12:08:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A8801234130; Sun, 22 Jan 2017 12:08:09 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8755B234130 for ; Sun, 22 Jan 2017 12:08:09 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A93D134167B for ; Sun, 22 Jan 2017 12:08:08 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 715F92C70 for ; Sun, 22 Jan 2017 12:08:07 +0000 (UTC) From: "Mart Raudsepp" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Mart Raudsepp" Message-ID: <1485086868.ed727d30df105b6852f5118baa5a454965b6f4ba.leio@gentoo> Subject: [gentoo-commits] proj/grumpy:master commit in: backend/lib/ X-VCS-Repository: proj/grumpy X-VCS-Files: backend/lib/sync.py X-VCS-Directories: backend/lib/ X-VCS-Committer: leio X-VCS-Committer-Name: Mart Raudsepp X-VCS-Revision: ed727d30df105b6852f5118baa5a454965b6f4ba X-VCS-Branch: master Date: Sun, 22 Jan 2017 12:08:07 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 650f0b39-393b-4bcd-a845-69b9bb9fc7ae X-Archives-Hash: 1bd57d346732c9acd2f6cd717f5a72ae commit: ed727d30df105b6852f5118baa5a454965b6f4ba Author: Mart Raudsepp gentoo org> AuthorDate: Sun Jan 22 12:07:48 2017 +0000 Commit: Mart Raudsepp gentoo org> CommitDate: Sun Jan 22 12:07:48 2017 +0000 URL: https://gitweb.gentoo.org/proj/grumpy.git/commit/?id=ed727d30 sync: Use dict comprehension in sync_categories as well backend/lib/sync.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/backend/lib/sync.py b/backend/lib/sync.py index dbb44c2..c837c23 100644 --- a/backend/lib/sync.py +++ b/backend/lib/sync.py @@ -117,10 +117,8 @@ def sync_categories(): data = http_session.get(url) # TODO: Handle response error (if not data) categories = data.json() - existing_categories = {} # TODO: Use UPSERT instead (on_conflict_do_update) if we can rely on postgresql:9.5 - for cat in Category.query.all(): - existing_categories[cat.name] = cat + existing_categories = {cat.name: cat for cat in Category.query.all()} for category in categories: if category['name'] in existing_categories: existing_categories[category['name']].description = category['description']