From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 20B5C59CB3 for ; Thu, 14 Apr 2016 02:34:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6435621C04C; Thu, 14 Apr 2016 02:34:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 79F8921C052 for ; Thu, 14 Apr 2016 02:34:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 7CEBE340DC2 for ; Thu, 14 Apr 2016 02:34:13 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 3478316C4 for ; Thu, 14 Apr 2016 02:34:09 +0000 (UTC) From: "Ryan Hill" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ryan Hill" Message-ID: <1460600935.0cac1248d35e67ae0b0119c1ec9799688ffd382d.rhill@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/ X-VCS-Repository: repo/gentoo X-VCS-Files: eclass/wxwidgets.eclass X-VCS-Directories: eclass/ X-VCS-Committer: rhill X-VCS-Committer-Name: Ryan Hill X-VCS-Revision: 0cac1248d35e67ae0b0119c1ec9799688ffd382d X-VCS-Branch: master Date: Thu, 14 Apr 2016 02:34:09 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: ba06e9b5-b5e0-45ce-8a96-d13321f90e91 X-Archives-Hash: 3ea4ec8a11c8a8daa06e0ebff51d5adb commit: 0cac1248d35e67ae0b0119c1ec9799688ffd382d Author: Ryan Hill gentoo org> AuthorDate: Sun Feb 21 09:33:15 2016 +0000 Commit: Ryan Hill gentoo org> CommitDate: Thu Apr 14 02:28:55 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0cac1248 wxwidgets.eclass: Clarify debugging comment It was potentially confusing that setting WX_DISABLE_DEBUG would actually cause debugging to be enabled. Changed variable name to WX_DISABLE_NDEBUG. eclass/wxwidgets.eclass | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/eclass/wxwidgets.eclass b/eclass/wxwidgets.eclass index 0e131d5..5bcc93c 100644 --- a/eclass/wxwidgets.eclass +++ b/eclass/wxwidgets.eclass @@ -67,10 +67,10 @@ unset _wxconf # In wxGTK-2.9 and later it also controls the level of debugging output # from the libraries. In these versions debugging features are enabled # by default and need to be disabled at the package level. Because this -# causes many warning dialogs to regularly pop up we add -DNDEBUG to -# CPPFLAGS by default, unless your ebuild has a debug USE flag and it's -# enabled. If you don't like this behavior you can set WX_DISABLE_DEBUG -# to disable it. +# causes many warning dialogs to pop up during runtime we add -DNDEBUG to +# CPPFLAGS to disable debugging features (unless your ebuild has a debug +# USE flag and it's enabled). If you don't like this behavior you can set +# WX_DISABLE_NDEBUG to override it. # # See: http://docs.wxwidgets.org/trunk/overview_debugging.html @@ -83,13 +83,13 @@ setup-wxwidgets() { case "${WX_GTK_VER}" in 3.0-gtk3) wxtoolkit=gtk3 - if [[ -z ${WX_DISABLE_DEBUG} ]]; then + if [[ -z ${WX_DISABLE_NDEBUG} ]]; then use_if_iuse debug || append-cppflags -DNDEBUG fi ;; 2.9|3.0) wxtoolkit=gtk2 - if [[ -z ${WX_DISABLE_DEBUG} ]]; then + if [[ -z ${WX_DISABLE_NDEBUG} ]]; then use_if_iuse debug || append-cppflags -DNDEBUG fi ;;