From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-837379-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4314913881E for <garchives@archives.gentoo.org>; Mon, 28 Sep 2015 19:10:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 29902E0802; Mon, 28 Sep 2015 19:10:08 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BF1FBE0802 for <gentoo-commits@lists.gentoo.org>; Mon, 28 Sep 2015 19:10:07 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 9D3AC34074E for <gentoo-commits@lists.gentoo.org>; Mon, 28 Sep 2015 19:10:05 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 35B60C4 for <gentoo-commits@lists.gentoo.org>; Mon, 28 Sep 2015 19:10:03 +0000 (UTC) From: "Brian Dolbec" <dolsen@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" <dolsen@gentoo.org> Message-ID: <1443467243.24779b15daef7101111c12de2dd6a6a5c3e374d4.dolsen@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/phase-helpers.sh X-VCS-Directories: bin/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: 24779b15daef7101111c12de2dd6a6a5c3e374d4 X-VCS-Branch: master Date: Mon, 28 Sep 2015 19:10:03 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 19c1f166-824a-4cc6-a419-ffa4d96a7d5d X-Archives-Hash: 023c4101e4ace54900d1bd5c50dc54b3 commit: 24779b15daef7101111c12de2dd6a6a5c3e374d4 Author: Mike Gilbert <floppym <AT> gentoo <DOT> org> AuthorDate: Sun Sep 27 13:24:49 2015 +0000 Commit: Brian Dolbec <dolsen <AT> gentoo <DOT> org> CommitDate: Mon Sep 28 19:07:23 2015 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=24779b15 Revert "unpack: avoid useless chmods to improve speed" This reverts commit 0dc7b2a3923508896cf217f325b8339d73353553. The "optimized" chmod is no longer recursive, which causes files to be missed. X-Gentoo-Bug: 561368 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=561368 bin/phase-helpers.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh index b446060..efd2cfa 100644 --- a/bin/phase-helpers.sh +++ b/bin/phase-helpers.sh @@ -531,8 +531,8 @@ unpack() { done # Do not chmod '.' since it's probably ${WORKDIR} and PORTAGE_WORKDIR_MODE # should be preserved. - find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \ - -exec chmod -f a+rX,u+w,g-w,o-w '{}' + + find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \ + ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w } econf() {