From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 55962138CAE for ; Wed, 22 Apr 2015 00:00:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3AD55E07E0; Wed, 22 Apr 2015 00:00:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E0DAFE07D3 for ; Wed, 22 Apr 2015 00:00:36 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 25238340A3C for ; Wed, 22 Apr 2015 00:00:36 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id B909B16721 for ; Wed, 22 Apr 2015 00:00:32 +0000 (UTC) From: "William Hubbs" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "William Hubbs" Message-ID: <1429659026.de7d184909d561b68b411325d32471c047549bca.williamh@OpenRC> Subject: [gentoo-commits] proj/openrc:master commit in: init.d/ X-VCS-Repository: proj/openrc X-VCS-Files: init.d/savecache.in X-VCS-Directories: init.d/ X-VCS-Committer: williamh X-VCS-Committer-Name: William Hubbs X-VCS-Revision: de7d184909d561b68b411325d32471c047549bca X-VCS-Branch: master Date: Wed, 22 Apr 2015 00:00:32 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 82ae7bd0-b4c9-47b4-a68b-c227f8bded85 X-Archives-Hash: 482cc25e55eba02e426f5f26a483f8f6 commit: de7d184909d561b68b411325d32471c047549bca Author: William Hubbs gmail com> AuthorDate: Tue Apr 21 23:30:26 2015 +0000 Commit: William Hubbs gentoo org> CommitDate: Tue Apr 21 23:30:26 2015 +0000 URL: https://gitweb.gentoo.org/proj/openrc.git/commit/?id=de7d1849 savecache: fix check for $RC_LIBEXECDIR writability We were originally checking to see if $RC_LIBEXECDIR/cache was writable. For a new install, this check will fail since this path does not exist. This is also incorrect because later we create $RC_LIBEXECDIR/cache. The correct check is checkpath -W $RC_LIBEXECDIR, and this fixes the issue. X-Gentoo-Bug: 544632 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=544632 init.d/savecache.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/init.d/savecache.in b/init.d/savecache.in index 4fcf3db..9040732 100644 --- a/init.d/savecache.in +++ b/init.d/savecache.in @@ -13,8 +13,8 @@ start() return 1 fi fi - if [ -e "$RC_LIBEXECDIR"/cache ] && ! checkpath -W "$RC_LIBEXECDIR"/cache; then - ewarn "WARNING: ${RC_LIBEXECDIR}/cache is not writable!" + if ! checkpath -W "$RC_LIBEXECDIR"; then + ewarn "WARNING: ${RC_LIBEXECDIR} is not writable!" if ! yesno "${RC_GOINGDOWN}"; then ewarn "Unable to save deptree cache" return 1