From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-792760-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D1DF7138CA3 for <garchives@archives.gentoo.org>; Mon, 13 Apr 2015 17:27:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 457FCE08BA; Mon, 13 Apr 2015 17:27:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0085BE08BA for <gentoo-commits@lists.gentoo.org>; Mon, 13 Apr 2015 17:27:38 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0D588340AAD for <gentoo-commits@lists.gentoo.org>; Mon, 13 Apr 2015 17:27:38 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 921B715D8C for <gentoo-commits@lists.gentoo.org>; Mon, 13 Apr 2015 17:27:34 +0000 (UTC) From: "Brian Dolbec" <dolsen@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" <dolsen@gentoo.org> Message-ID: <1428945744.3ed886e510a4c905d80c500665a1ce4e245b19d5.dolsen@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/repoman X-VCS-Directories: bin/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: 3ed886e510a4c905d80c500665a1ce4e245b19d5 X-VCS-Branch: master Date: Mon, 13 Apr 2015 17:27:34 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 385203ca-fce2-41d8-b7c8-6f2571032bdb X-Archives-Hash: 3da0e7ab08fdac2af2147362dfec1582 commit: 3ed886e510a4c905d80c500665a1ce4e245b19d5 Author: Brian Dolbec <dolsen <AT> gentoo <DOT> org> AuthorDate: Mon Apr 13 17:19:46 2015 +0000 Commit: Brian Dolbec <dolsen <AT> gentoo <DOT> org> CommitDate: Mon Apr 13 17:22:24 2015 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=3ed886e5 bin/repoman: Catch the case of gpgcmd == '' prometheanfire was getting '' (null string) returned, so it was not erroring like it should. bin/repoman | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/repoman b/bin/repoman index 5ff6857..e9c89c2 100755 --- a/bin/repoman +++ b/bin/repoman @@ -2953,7 +2953,7 @@ else: # Setup the GPG commands def gpgsign(filename): gpgcmd = repoman_settings.get("PORTAGE_GPG_SIGNING_COMMAND") - if gpgcmd is None: + if gpgcmd in [None, '']: raise MissingParameter("PORTAGE_GPG_SIGNING_COMMAND is unset!" + \ " Is make.globals missing?") if "${PORTAGE_GPG_KEY}" in gpgcmd and \