From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1CD8C138A1C for ; Wed, 19 Nov 2014 23:26:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A1028E091B; Wed, 19 Nov 2014 23:26:47 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 20724E091B for ; Wed, 19 Nov 2014 23:26:47 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3FF6B34053A for ; Wed, 19 Nov 2014 23:26:46 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id DA85CA7DF for ; Wed, 19 Nov 2014 23:26:44 +0000 (UTC) From: "Michał Górny" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michał Górny" Message-ID: <1416439594.64e61b42cc85374f562f15a22a408218c5c5a8f4.mgorny@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/ X-VCS-Repository: proj/portage X-VCS-Files: bin/install-qa-check.d/05double-D bin/install-qa-check.d/90world-writable X-VCS-Directories: bin/install-qa-check.d/ X-VCS-Committer: mgorny X-VCS-Committer-Name: Michał Górny X-VCS-Revision: 64e61b42cc85374f562f15a22a408218c5c5a8f4 X-VCS-Branch: master Date: Wed, 19 Nov 2014 23:26:44 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 3e2c1233-9ce6-4194-b73d-0d4de3f36e02 X-Archives-Hash: 7919f430f53603c1d7a195ce25a67edf commit: 64e61b42cc85374f562f15a22a408218c5c5a8f4 Author: Michał Górny gentoo org> AuthorDate: Sun Nov 2 19:15:20 2014 +0000 Commit: Michał Górny gentoo org> CommitDate: Wed Nov 19 23:26:34 2014 +0000 URL: http://sources.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=64e61b42 Update the QA checks to new eqatag API --- bin/install-qa-check.d/05double-D | 8 ++++---- bin/install-qa-check.d/90world-writable | 4 +--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/bin/install-qa-check.d/05double-D b/bin/install-qa-check.d/05double-D index 7d958f1..4b7737c 100644 --- a/bin/install-qa-check.d/05double-D +++ b/bin/install-qa-check.d/05double-D @@ -3,12 +3,12 @@ DD_check() { if [[ -d ${D%/}${D} ]] ; then eqawarn "QA Notice: files installed in \${D}/\${D}:" - local -i INSTALLTOD=0 + local files=() while read -r -d $'\0' i ; do - __eqawarnlog double-d "/${i##${D%/}${D}}" - ((INSTALLTOD++)) + files+=( "${i#${D%/}${D}}" ) done < <(find "${D%/}${D}" -print0) - die "Aborting due to QA concerns: ${INSTALLTOD} files installed in ${D%/}${D}" + eqatag -v double-D "${files[@]/#//}" + die "Aborting due to QA concerns: ${#files[@]} files installed in ${D%/}${D}" fi } diff --git a/bin/install-qa-check.d/90world-writable b/bin/install-qa-check.d/90world-writable index 490aaee..2b435ac 100644 --- a/bin/install-qa-check.d/90world-writable +++ b/bin/install-qa-check.d/90world-writable @@ -12,9 +12,7 @@ world_writable_check() { if [[ -n ${unsafe_files} ]] ; then eqawarn "QA Security Notice: world writable file(s):" - for x in $unsafe_files ; do - __eqawarnlog world-writable "$x" - done + eqatag -v world-writable $unsafe_files eqawarn "This may or may not be a security problem, most of the time it is one." eqawarn "Please double check that $PF really needs a world writeable bit and file bugs accordingly."