public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Richard Yao" <ryao@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/genkernel:ryao commit in: /
Date: Sun,  9 Jun 2013 08:16:02 +0000 (UTC)	[thread overview]
Message-ID: <1370765692.9d8ecf17fdab02852b831be6e5f613be88ad36a4.ryao@gentoo> (raw)

commit:     9d8ecf17fdab02852b831be6e5f613be88ad36a4
Author:     Richard Yao <ryao <AT> cs <DOT> stonybrook <DOT> edu>
AuthorDate: Sun Jun  9 08:13:08 2013 +0000
Commit:     Richard Yao <ryao <AT> gentoo <DOT> org>
CommitDate: Sun Jun  9 08:14:52 2013 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commit;h=9d8ecf17

Revert "Make errors stand out more"

Having the debug shell appear whenever an error occurred was incredibly
useful. Commit 5a7bc18180612f5ada377be3df1ae20596ebfdac broke that, so
we revert it.

---
 gen_funcs.sh | 35 +++++++++++++++++------------------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/gen_funcs.sh b/gen_funcs.sh
index 4f0a0fc..2d47976 100755
--- a/gen_funcs.sh
+++ b/gen_funcs.sh
@@ -204,30 +204,29 @@ gen_die() {
 	then
 		print_error 1 "ERROR: ${1}"
 	fi
-	print_error 1 ''
-	print_error 1 "-- Grepping log... --"
-	print_error 1 ''
+	echo
+	print_info 1 "-- Grepping log... --"
+	echo
 
 	if isTrue ${USECOLOR}
 	then
-		GREP_COLOR='1' grep -B5 -E --colour=always "([Ww][Aa][Rr][Nn][Ii][Nn][Gg]|[Ee][Rr][Rr][Oo][Rr][ :,!]|[Ff][Aa][Ii][Ll][Ee]?[Dd]?)" ${LOGFILE} \
-				| sed -s "s|^\(*\)\?|${BAD}*${NORMAL}|"
+		GREP_COLOR='1' grep -B5 -E --colour=always "([Ww][Aa][Rr][Nn][Ii][Nn][Gg]|[Ee][Rr][Rr][Oo][Rr][ :,!]|[Ff][Aa][Ii][Ll][Ee]?[Dd]?)" ${LOGFILE}
 	else
 		grep -B5 -E "([Ww][Aa][Rr][Nn][Ii][Nn][Gg]|[Ee][Rr][Rr][Oo][Rr][ :,!]|[Ff][Aa][Ii][Ll][Ee]?[Dd]?)" ${LOGFILE}
 	fi
-	print_error 1 ''
-	print_error 1 "-- End log... --"
-	print_error 1 ''
-	print_error 1 "Please consult ${LOGFILE} for more information and any"
-	print_error 1 "errors that were reported above."
-	print_error 1 ''
-	print_error 1 "Report any genkernel bugs to bugs.gentoo.org and"
-	print_error 1 "assign your bug to genkernel@gentoo.org. Please include"
-	print_error 1 "as much information as you can in your bug report; attaching"
-	print_error 1 "${LOGFILE} so that your issue can be dealt with effectively."
-	print_error 1 ''
-	print_error 1 'Please do *not* report compilation failures as genkernel bugs!'
-	print_error 1 ''
+	echo
+	print_info 1 "-- End log... --"
+	echo
+	print_info 1 "Please consult ${LOGFILE} for more information and any"
+	print_info 1 "errors that were reported above."
+	echo
+	print_info 1 "Report any genkernel bugs to bugs.gentoo.org and"
+	print_info 1 "assign your bug to genkernel@gentoo.org. Please include"
+	print_info 1 "as much information as you can in your bug report; attaching"
+	print_info 1 "${LOGFILE} so that your issue can be dealt with effectively."
+	print_info 1 ''
+	print_info 1 'Please do *not* report compilation failures as genkernel bugs!'
+	print_info 1 ''
 
 	# Cleanup temp dirs and caches if requested
 	cleanup


             reply	other threads:[~2013-06-09  8:16 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09  8:16 Richard Yao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-02 12:43 [gentoo-commits] proj/genkernel:ryao commit in: / Richard Yao
2013-10-02 12:43 Richard Yao
2013-10-02 12:43 Richard Yao
2013-06-09 13:57 Richard Yao
2013-06-09 13:57 [gentoo-commits] proj/genkernel:master " Richard Yao
2013-06-09 13:57 ` [gentoo-commits] proj/genkernel:ryao " Richard Yao
2013-06-09 13:57 Richard Yao
2013-06-09 13:33 Richard Yao
2013-06-09 13:33 Richard Yao
2013-06-09 13:17 Richard Yao
2013-06-09 13:17 Richard Yao
2013-06-09 10:05 Richard Yao
2013-06-09 10:05 Richard Yao
2013-06-09 10:02 Richard Yao
2013-06-09 10:02 Richard Yao
2013-06-09  9:58 Richard Yao
2013-06-09  9:58 Richard Yao
2013-06-09  9:57 Richard Yao
2013-06-09  9:53 Richard Yao
2013-06-09  9:51 Richard Yao
2013-06-09  9:49 Richard Yao
2013-06-09  8:32 Richard Yao
2013-06-09  8:32 Richard Yao
2013-06-09  8:32 Richard Yao
2013-06-09  8:32 Richard Yao
2013-06-09  8:32 Richard Yao
2013-06-09  7:58 Richard Yao
2013-06-09  6:43 Richard Yao
2013-06-06  6:09 Richard Yao
2013-06-06  5:57 Richard Yao
2013-06-06  5:54 Richard Yao
2013-06-06  3:52 Richard Yao
2013-06-06  3:36 Richard Yao
2013-06-06  3:36 Richard Yao
2013-06-06  3:36 Richard Yao
2013-06-06  3:36 Richard Yao
2013-06-03 23:49 [gentoo-commits] proj/genkernel:master " Richard Yao
2013-06-06  3:36 ` [gentoo-commits] proj/genkernel:ryao " Richard Yao
2013-06-03 23:49 Richard Yao
2013-06-03 23:47 Richard Yao
2013-06-03 23:43 Richard Yao
2013-06-03 23:35 Richard Yao
2013-06-03 23:34 Richard Yao
2013-06-03 23:34 Richard Yao
2012-11-11 18:04 Richard Yao
2012-11-11 17:32 Richard Yao
2012-11-05 18:42 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-11-05 18:30 Richard Yao
2012-08-25  1:44 Richard Yao
2012-08-25  1:36 Richard Yao
2012-08-25  1:19 Richard Yao
2012-08-25  1:04 Richard Yao
2012-08-16 18:33 Richard Yao
2012-08-16 18:33 Richard Yao
2012-08-16 18:33 Richard Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370765692.9d8ecf17fdab02852b831be6e5f613be88ad36a4.ryao@gentoo \
    --to=ryao@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox