From: "Paul Varner" <fuzzyray@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gentoolkit:gentoolkit commit in: pym/gentoolkit/
Date: Tue, 13 Nov 2012 20:40:59 +0000 (UTC) [thread overview]
Message-ID: <1352688525.d505769fd55daab8ed64534b000732a801f5b2fa.fuzzyray@gentoo> (raw)
commit: d505769fd55daab8ed64534b000732a801f5b2fa
Author: W. Trevor King <wking <AT> tremily <DOT> us>
AuthorDate: Mon Nov 12 02:45:38 2012 +0000
Commit: Paul Varner <fuzzyray <AT> gentoo <DOT> org>
CommitDate: Mon Nov 12 02:48:45 2012 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/gentoolkit.git;a=commit;h=d505769f
dependencies: avoid Package-is-not-iterable in graph_reverse_depends doctest
Dependency is a subclass of Query, so we need to initialize it with a
CPV string, not a Package instance. The old doctest was raising:
File ".../pym/gentoolkit/dependencies.py", line 202, in
gentoolkit.dependencies.Dependencies.graph_reverse_depends
Failed example:
deptree = ffmpeg.graph_reverse_depends(
only_direct=False, # Include indirect revdeps
pkgset=installed) # from installed pkgset
Exception raised:
Traceback (most recent call last):
File "/usr/lib/python3.2/doctest.py", line 1288, in __run
compileflags, 1), test.globs)
File "<doctest gentoolkit.dependencies.Dependencies.graph_reverse_depends[5]>", line 3, in <module>
pkgset=installed) # from installed pkgset
File ".../pym/gentoolkit/dependencies.py", line 237, in graph_reverse_depends
pkgset = tuple(Dependencies(x) for x in pkgset)
File ".../pym/gentoolkit/dependencies.py", line 237, in <genexpr>
pkgset = tuple(Dependencies(x) for x in pkgset)
File ".../pym/gentoolkit/dependencies.py", line 45, in __init__
Query.__init__(self, query)
File "/home/wking/src/gentoolkit/pym/gentoolkit/query.py", line 51, in __init__
if not set(query).intersection(needed_chars):
TypeError: 'Package' object is not iterable
Also use ffmpeg-9999 (for better future-proofing) and update the
length of the resulting deptree.
---
pym/gentoolkit/dependencies.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/pym/gentoolkit/dependencies.py b/pym/gentoolkit/dependencies.py
index 726d546..3019a54 100644
--- a/pym/gentoolkit/dependencies.py
+++ b/pym/gentoolkit/dependencies.py
@@ -192,18 +192,18 @@ class Dependencies(Query):
Example usage:
>>> from gentoolkit.dependencies import Dependencies
- >>> ffmpeg = Dependencies('media-video/ffmpeg-0.5_p20373')
+ >>> ffmpeg = Dependencies('media-video/ffmpeg-9999')
>>> # I only care about installed packages that depend on me:
... from gentoolkit.helpers import get_installed_cpvs
>>> # I want to pass in a sorted list. We can pass strings or
... # Package or Atom types, so I'll use Package to sort:
... from gentoolkit.package import Package
- >>> installed = sorted(Package(x) for x in get_installed_cpvs())
+ >>> installed = sorted(get_installed_cpvs())
>>> deptree = ffmpeg.graph_reverse_depends(
... only_direct=False, # Include indirect revdeps
... pkgset=installed) # from installed pkgset
>>> len(deptree)
- 44
+ 24
@type pkgset: iterable
@keyword pkgset: sorted pkg cpv strings or anything sublassing
next reply other threads:[~2012-11-13 20:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 20:40 Paul Varner [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-02 22:10 [gentoo-commits] proj/gentoolkit:gentoolkit commit in: pym/gentoolkit/ Paul Varner
2014-02-22 19:28 Brian Dolbec
2013-03-12 16:06 Mike Frysinger
2013-01-04 22:23 Paul Varner
2012-12-30 20:25 Brian Dolbec
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-11-13 20:40 Paul Varner
2012-10-09 21:35 Paul Varner
2012-08-01 3:34 Brian Dolbec
2012-07-24 17:18 Paul Varner
2012-05-16 21:18 Paul Varner
2012-03-02 0:01 Brian Dolbec
2011-12-23 6:05 Brian Dolbec
2011-07-16 4:04 Paul Varner
2011-07-16 3:21 Paul Varner
2011-07-15 20:02 Paul Varner
2011-05-23 3:45 Brian Dolbec
2011-05-20 5:54 Brian Dolbec
2011-05-18 21:18 Brian Dolbec
2011-04-18 18:28 Paul Varner
2011-03-31 21:53 Paul Varner
2011-02-23 9:10 Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352688525.d505769fd55daab8ed64534b000732a801f5b2fa.fuzzyray@gentoo \
--to=fuzzyray@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox